Page MenuHomePhabricator

New 'limit' config in OO.ui.TagMultiselectWidget conflicts with 'limit' in mw.widgets.TitleWidget
Closed, ResolvedPublic


This is a problem for mw.widgets.TitlesMultiselectWidget, which inherits from OO.ui.TagMultiselectWidget and mixes in mw.widgets.TitleWidget.

Ideally the solution would be to rename the config in mw.widgets.TitleWidget, since it is the mixin, but that would have wide repercussions.

Would be less disruptive to rename the new config in OO.ui.TagMultiselectWidget.

Event Timeline

Tchanders created this task.Nov 8 2018, 1:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2018, 1:38 PM

Change 472446 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] TagMultiselectWidget: rename limit config to tagLimit

Change 472457 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] TitlesMultiselectWidget: rename 'limit' config to 'tagLimit'

Change 472446 merged by jenkins-bot:
[oojs/ui@master] TagMultiselectWidget: rename 'limit' config to 'tagLimit'

Change 472587 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.5

Change 472587 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.5

Volker_E closed this task as Resolved.Nov 12 2018, 12:52 AM
Volker_E triaged this task as Normal priority.
Volker_E moved this task from Backlog to OOUI-0.29.5 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.29.5); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.

Change 472457 merged by jenkins-bot:
[mediawiki/core@master] TitlesMultiselectWidget: rename 'limit' config to 'tagLimit'