Page MenuHomePhabricator
Create Task
Maniphest T209057

New 'limit' config in OO.ui.TagMultiselectWidget conflicts with 'limit' in mw.widgets.TitleWidget
Closed, ResolvedPublic
Actions

Description

This is a problem for mw.widgets.TitlesMultiselectWidget, which inherits from OO.ui.TagMultiselectWidget and mixes in mw.widgets.TitleWidget.

Ideally the solution would be to rename the config in mw.widgets.TitleWidget, since it is the mixin, but that would have wide repercussions.

Would be less disruptive to rename the new config in OO.ui.TagMultiselectWidget.

Details

SubjectRepoBranchLines +/-
TitlesMultiselectWidget: rename 'limit' config to 'tagLimit'mediawiki/coremaster+7 -7
Update OOUI to v0.29.5mediawiki/coremaster+63 -63
TagMultiselectWidget: rename 'limit' config to 'tagLimit'oojs/uimaster+16 -17
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Nov 8 2018, 1:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2018, 1:38 PM
gerritbot subscribed.Nov 8 2018, 1:42 PM

Change 472446 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] TagMultiselectWidget: rename limit config to tagLimit

https://gerrit.wikimedia.org/r/472446

gerritbot added a project: Patch-For-Review.Nov 8 2018, 1:42 PM
gerritbot added a comment.Nov 8 2018, 2:31 PM

Change 472457 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] TitlesMultiselectWidget: rename 'limit' config to 'tagLimit'

https://gerrit.wikimedia.org/r/472457

Tchanders moved this task from In progress to Review on the Anti-Harassment (AHT Sprint 32) board.Nov 8 2018, 3:15 PM
gerritbot added a comment.Nov 8 2018, 4:36 PM

Change 472446 merged by jenkins-bot:
[oojs/ui@master] TagMultiselectWidget: rename 'limit' config to 'tagLimit'

https://gerrit.wikimedia.org/r/472446

• TBolliger moved this task from AHT Sprint 32 to AHT Sprint 33 on the Anti-Harassment board.Nov 8 2018, 8:02 PM
• TBolliger edited projects, added Anti-Harassment (AHT Sprint 33); removed Anti-Harassment (AHT Sprint 32).
• TBolliger moved this task from Ready to Review on the Anti-Harassment (AHT Sprint 33) board.Nov 8 2018, 8:04 PM
gerritbot added a comment.Nov 8 2018, 10:43 PM

Change 472587 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.5

https://gerrit.wikimedia.org/r/472587

gerritbot added a comment.Nov 8 2018, 11:10 PM

Change 472587 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.5

https://gerrit.wikimedia.org/r/472587

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 9 2018, 12:01 AM
Tchanders mentioned this in T208627: TitlesMultiselectWidget for Partial blocks suggests and accepts for more pages than the maximum.Nov 9 2018, 2:37 PM
Volker_E closed this task as Resolved.Nov 12 2018, 12:52 AM
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Backlog to OOUI-0.29.5 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.29.5); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
gerritbot added a comment.Nov 13 2018, 8:10 PM

Change 472457 merged by jenkins-bot:
[mediawiki/core@master] TitlesMultiselectWidget: rename 'limit' config to 'tagLimit'

https://gerrit.wikimedia.org/r/472457

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 13 2018, 9:00 PM
• TBolliger moved this task from Review to Done on the Anti-Harassment (AHT Sprint 33) board.Nov 15 2018, 10:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL