Page MenuHomePhabricator
Create Task
Maniphest T211413

Test if 2x/1x logo version is 2 times bigger than 1x logo version
Closed, ResolvedPublic
Actions

Description

Sometime, a dev uploads a logo of an incorrect size. This test should catch those cases.

Details

SubjectRepoBranchLines +/-
Test if 2x logo version is 2 times bigger than 1x logo versionoperations/mediawiki-configmaster+28 -0
Fix several incorrect logo sizesoperations/mediawiki-configmaster+1 -1
Remove fawikiquote HD logooperations/mediawiki-configmaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Dec 7 2018, 10:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2018, 10:51 AM
Shreyasminocha subscribed.Dec 7 2018, 10:52 AM
Urbanecm triaged this task as Low priority.Dec 7 2018, 9:38 PM
Urbanecm moved this task from Backlog to Analytics/Under discussion on the User-Urbanecm board.Dec 11 2018, 11:17 AM
Urbanecm removed a project: User-Urbanecm.Jan 20 2019, 4:03 PM
gerritbot added a comment.Jul 7 2019, 10:17 PM

Change 521181 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Test if 2x logo version is 2 times bigger than 1x logo version

https://gerrit.wikimedia.org/r/521181

gerritbot added a project: Patch-For-Review.Jul 7 2019, 10:17 PM
Urbanecm claimed this task.Jul 7 2019, 10:46 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJul 7 2019, 10:46 PM
Urbanecm moved this task from Analytics/Under discussion to Working on on the User-Urbanecm board.Jul 8 2019, 12:30 PM
gerritbot added a comment.Jul 8 2019, 4:53 PM

Change 521316 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Fix several incorrect logo sizes

https://gerrit.wikimedia.org/r/521316

Urbanecm renamed this task from Test if 2x logo version is 2 times bigger than 1x logo version to Test if 2x/1x logo version is 2 times bigger than 1x logo version.Jul 9 2019, 4:30 PM
Urbanecm updated the task description. (Show Details)
Urbanecm moved this task from Working on to To deploy on the User-Urbanecm board.Jul 10 2019, 6:57 AM
gerritbot added a comment.Jul 10 2019, 6:58 AM

Change 521527 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Remove fawikiquote HD logo

https://gerrit.wikimedia.org/r/521527

gerritbot added a comment.Jul 10 2019, 11:02 AM

Change 521527 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove fawikiquote HD logo

https://gerrit.wikimedia.org/r/521527

gerritbot added a comment.Jul 10 2019, 11:02 AM

Change 521316 merged by jenkins-bot:
[operations/mediawiki-config@master] Fix several incorrect logo sizes

https://gerrit.wikimedia.org/r/521316

Stashbot mentioned this in T227635: Optimise logos.Jul 10 2019, 11:07 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-10T11:07:43Z] <urbanecm@deploy1001> sync-file aborted: SWAT: Several logo changes (T227635 T211413) (duration: 00m 20s)

Stashbot added a comment.Jul 10 2019, 11:09 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-10T11:09:03Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: Remove fawikiquote HD logo (T211413) (duration: 00m 57s)

Stashbot added a comment.Jul 10 2019, 11:10 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-10T11:10:07Z] <urbanecm@deploy1001> Synchronized static/images/project-logos/: SWAT: Several logo changes (T227635 T211413) (duration: 01m 00s)

Stashbot added a comment.Jul 10 2019, 11:53 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-10T11:53:37Z] <Urbanecm> Purged 14 urls for T211413

Urbanecm moved this task from To deploy to Waiting on review on the User-Urbanecm board.Jul 10 2019, 11:54 AM

I'd appreciate CR on this.

gerritbot added a comment.Apr 20 2020, 5:28 PM

Change 521181 merged by jenkins-bot:
[operations/mediawiki-config@master] Test if 2x logo version is 2 times bigger than 1x logo version

https://gerrit.wikimedia.org/r/521181

Jdforrester-WMF closed this task as Resolved.Apr 20 2020, 5:28 PM
Jdforrester-WMF subscribed.

Done. Some logos to fix, but we won't get worse.

Urbanecm mentioned this in T250731: Change HD logos with incorrect size to match expectations.Apr 20 2020, 5:32 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 20 2020, 6:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL