Page MenuHomePhabricator

Minor typos in EULS jquery.webfonts.js
Closed, ResolvedPublic

Description

2 small typos in comments.

  • Not worth a review process and deployment.
  • However, should be patched and distributed one day.
  • Perhaps there are some more.

rEULS /lib/jquery.webfonts/src/jquery.webfonts.js

  • Line 295 jquey.webfonts
  • Line 298 styles(See

Details

Related Gerrit Patches:
mediawiki/extensions/UniversalLanguageSelector : masterUpdate jquery.webfonts and jquery.uls from upstream

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2018, 10:17 AM
PerfektesChaos triaged this task as Lowest priority.Dec 16 2018, 10:17 AM

Thanks for reporting :)

Any chance you could send a pull request to https://github.com/wikimedia/jquery.webfonts ?

Sorry, no, I am overburdened and do not get into any code patching whatever business. Even more not into a different GitHub Account authorization identification password procedure administration; I do have some 50 access management issues like this open and do not add any further.

Zoranzoki21 closed this task as Resolved.Dec 16 2018, 3:02 PM
Zoranzoki21 assigned this task to Amire80.
Zoranzoki21 added a subscriber: Zoranzoki21.

Merged

KartikMistry reopened this task as Open.Dec 16 2018, 3:22 PM
KartikMistry added a subscriber: KartikMistry.

Not yet merged into UniversalLanguageSelector and also not deployed.

Change 479982 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.webfonts and jquery.uls from upstream

https://gerrit.wikimedia.org/r/479982

Change 479982 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.webfonts and jquery.uls from upstream

https://gerrit.wikimedia.org/r/479982

Amire80 closed this task as Resolved.Dec 17 2018, 8:19 AM