Page MenuHomePhabricator
Create Task
Maniphest T212075

Minor typos in EULS jquery.webfonts.js
Closed, ResolvedPublic
Actions

Description

2 small typos in comments.

  • Not worth a review process and deployment.
  • However, should be patched and distributed one day.
  • Perhaps there are some more.

rEULS /lib/jquery.webfonts/src/jquery.webfonts.js

  • Line 295 jquey.webfonts
  • Line 298 styles(See

Details

SubjectRepoBranchLines +/-
Update jquery.webfonts and jquery.uls from upstreammediawiki/extensions/UniversalLanguageSelectormaster+5 -5
Customize query in gerrit

Event Timeline

PerfektesChaos created this task.Dec 16 2018, 10:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2018, 10:17 AM
PerfektesChaos triaged this task as Lowest priority.Dec 16 2018, 10:17 AM
Amire80 subscribed.Dec 16 2018, 10:20 AM

Thanks for reporting :)

Any chance you could send a pull request to https://github.com/wikimedia/jquery.webfonts ?

PerfektesChaos added a comment.Dec 16 2018, 10:52 AM

Sorry, no, I am overburdened and do not get into any code patching whatever business. Even more not into a different GitHub Account authorization identification password procedure administration; I do have some 50 access management issues like this open and do not add any further.

Amire80 added a comment.Dec 16 2018, 12:22 PM

Addressed in https://github.com/wikimedia/jquery.webfonts/pull/49 .

Kizule closed this task as Resolved.Dec 16 2018, 3:02 PM
Kizule assigned this task to Amire80.
Kizule subscribed.

Merged

KartikMistry reopened this task as Open.Dec 16 2018, 3:22 PM
KartikMistry subscribed.

Not yet merged into UniversalLanguageSelector and also not deployed.

gerritbot subscribed.Dec 16 2018, 5:00 PM

Change 479982 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.webfonts and jquery.uls from upstream

https://gerrit.wikimedia.org/r/479982

gerritbot added a project: Patch-For-Review.Dec 16 2018, 5:00 PM
gerritbot added a comment.Dec 17 2018, 7:45 AM

Change 479982 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.webfonts and jquery.uls from upstream

https://gerrit.wikimedia.org/r/479982

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 17 2018, 8:00 AM
Amire80 closed this task as Resolved.Dec 17 2018, 8:19 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits