| Dragons_flight | |
| Jun 15 2009, 4:50 PM |
| F5723: 19219.png | |
| Nov 21 2014, 10:38 PM |
The recent software update seems to have added a blank whitespace between the Article, Discussion, etc... tabs and the page title. The appearance is as if the entire page text has been pushed down some within its bounding box. This is visible on both IE and Firefox and roughly the height of a normal line of text.
Version: unspecified
Severity: minor
matthew.britton wrote:
Affects monobook skin only on all Wikimedia wikis.
This is the change which did it:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/monobook/main.css?r1=50702&r2=51081
The change has no affect on the default appearence because by default there is no sitenotice div on the page. On Wikimedia wikis, the sitenotice div is always there, just empty when there is no notice. Thus this change added 0.9em of blank space. The "corrected" line should never have been there in the first place.
Fix is to remove that line.
Change appears to have been made due to mistaken impression of what the code did...
Explanation: "padding: 0 .9em" sets the top/bottom padding to 0 and the left/right padding to 0.9em.
"padding-top: 0.9em" sets the top padding to 0.9em and leaves the top/left/right padding unset -- totally different.
I'm changing it to "padding: 0 0.9em" to make it clearer that it's not a mistake for "0.9". Fixed in r52299.
Created attachment 6251
Screenshot of bad & good output w/ giant space of doom
To illustrate the problem for future generations.
Attached:
