Page MenuHomePhabricator
Create Task
Maniphest T212314

Review additional elements exposed by external services that may not work
Closed, ResolvedPublic
Actions

Description

When a page is delivered through an external translation service some functionality may be missing. Delivering the mobile version for such content (T212197) and adjusting the page actions (T212202), helps to reduce the functionality exposed that won't work on an external service.

In addition to that, the current ticket is intended to review other information and functionality in the page that may not work as expected in order to decide whether to hide it, disable it, or redirect to some wiki page instead. Some of the elements to review include the options provided in the "hamburger" menu, search, page issues, footer menus, and similar.

Details

SubjectRepoBranchLines +/-
Rewrite the menu URLs only when the source language is Englishmediawiki/extensions/ExternalGuidancemaster+6 -1
Rewrite the menu URLs so that they point to target languagemediawiki/extensions/ExternalGuidancemaster+19 -0
Customize query in gerrit

Related Objects

Event Timeline

Pginer-WMF created this task.Dec 19 2018, 5:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2018, 5:06 PM
Pginer-WMF renamed this task from Review additional actions exposed on external services to Review additional elements exposed on external services.Dec 19 2018, 6:08 PM
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF triaged this task as Medium priority.Dec 20 2018, 10:01 AM
Pginer-WMF renamed this task from Review additional elements exposed on external services to Review additional elements exposed by external services that may not work.Dec 20 2018, 10:25 AM
Pginer-WMF added a comment.Dec 24 2018, 12:47 PM

On Google Translate and Bing translator a message is shown claiming that "You are centrally logged-in" and asking to reload the page to log-in which is not the case.

Screen Shot 2018-12-24 at 13.11.06.png (539×1 px, 288 KB)

In an external context such as these, users cannot be logged-in an we want to avoid conveying that message. This may require some adjustments in the way MediaWiki-extensions-CentralAuth works.

santhosh claimed this task.Jan 8 2019, 11:52 AM
santhosh moved this task from Backlog to In Progress on the ExternalGuidance board.

So far we hide all pen icons(edit links) and the top bar containing language selector, mark as favorite, download, and edit.

santhosh added a comment.Jan 9 2019, 6:01 AM

Two items that need fix:

  • Hamburguer menu options should link to the target wiki. - Options inside the menu (home, random, log in, and preferences), should link to those pages in the target wiki.
  • Search bar is not working. Keeps loading forever - Investigate whether this is a limitation of the instance or cannot be supported. Based on that, we can support, redirect or hide the funcionality.
gerritbot subscribed.Jan 9 2019, 12:07 PM

Change 483104 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ExternalGuidance@master] Rewrite the menu URLs so that they point to target language

https://gerrit.wikimedia.org/r/483104

gerritbot added a project: Patch-For-Review.Jan 9 2019, 12:07 PM
santhosh mentioned this in T212518: Add a search API configuration override.Jan 10 2019, 5:38 AM
gerritbot added a comment.Jan 18 2019, 4:18 AM

Change 483104 merged by Santhosh:
[mediawiki/extensions/ExternalGuidance@master] Rewrite the menu URLs so that they point to target language

https://gerrit.wikimedia.org/r/483104

gerritbot added a comment.Feb 5 2019, 8:59 AM

Change 488003 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ExternalGuidance@master] Rewrite the menu URLs only when the source language is English

https://gerrit.wikimedia.org/r/488003

santhosh moved this task from In Progress to In Review on the ExternalGuidance board.Feb 5 2019, 9:03 AM
gerritbot added a comment.Feb 7 2019, 1:36 PM

Change 488003 merged by jenkins-bot:
[mediawiki/extensions/ExternalGuidance@master] Rewrite the menu URLs only when the source language is English

https://gerrit.wikimedia.org/r/488003

santhosh moved this task from In Review to Done on the ExternalGuidance board.Feb 26 2019, 3:42 AM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:42 PM
Aklapper removed santhosh as the assignee of this task.Jul 2 2021, 5:19 AM
Aklapper added a subscriber: santhosh.

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Aklapper closed this task as Resolved.Dec 21 2022, 8:38 AM
Aklapper assigned this task to santhosh.

All patches merged or abandoned and no updates for years. Assuming this is resolved. (Please resolve tasks when they are complete done - thanks.)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits