Page MenuHomePhabricator

Drop current implementation of botirc.IRCBot
Closed, ResolvedPublic


botirc.IRCBot was converted from compat where it was used by

The current implementation isn't usable anymore because the irclib was moved 6 years ago and was never ported to core. In addition with eventstreams we have a better implementation for recent changes stream.

Maybe we can reuse this IRCBot class for a more generic IRCBot.

Event Timeline

Xqt created this task.Dec 26 2018, 6:26 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptDec 26 2018, 6:26 PM
Dvorapa added a subscriber: Dvorapa.EditedMay 8 2019, 11:44 PM

My tests today revealed, that IRCBot doesn't fail for syntax errors, which is weird, because it clearly contains some.

Xqt added a comment.May 9 2019, 9:21 AM

I played a bit with it few months ago and didn't found any advantage to derive the the IRCBot from pywikibot.Bot. I don't know what script_wui is doing with it. There are no other applications using it. Maybe operators may use is with their own script but I feel our implementation is to special than it is very usefull.

Btw stewardBot is and was using SingleServerIRCBot directly.

The intention noted in the script:

# Note: the intention is to develop this module (at some point) into a Bot
# class definition that can be subclassed to create new, functional bot
# scripts, instead of writing each one from scratch.

is to vague and I have no glue, in which direction this development can lead.
That library was not mainainted for 6 years if ever.

After dropping script_wui I propose to drop this framework script too.
Maybe the needed parts can be moved to the deprecated script_wui.

Change 481338 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Drop library part

As it can be replaced by eventstreams and is not used anywhere else, I agree to deprecate it.

Change 509039 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [IMPR] Switch script_wui to EventStreams

Change 509039 abandoned by Dvorapa:
[IMPR] Switch script_wui to EventStreams

I changed my mind. This can use botirc and together with botirc can be removed after some time as standard deprecation routine

Change 481338 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Drop library part

Dvorapa closed this task as Resolved.May 11 2019, 11:05 AM
Dvorapa claimed this task.

botirc dropped successfully, irc library or EventStreams can be used instead

Dvorapa reassigned this task from Dvorapa to Xqt.May 11 2019, 11:05 AM

Change 563664 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [cleanup] Remove deprecated lib as announced in HISTORY.rst

Change 563664 merged by jenkins-bot:
[pywikibot/core@master] [cleanup] Remove deprecated lib as announced in HISTORY.rst