Create a custom Wikibase diff view for WBMI so that we can suppress the "entity" line, and use a different description for "caption" instead of "label"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Jan 9 2019, 9:44 PM

Description

https://test-commons.wikimedia.org/w/index.php?title=File:Bluesq.png&diff=541&oldid=539&diffmode=source

Addshore claims it's supported.

Details

	Subject	Repo	Branch	Lines +/-
	Add basic custom DiffVisualizer	mediawiki/extensions/WikibaseMediaInfo	master	+161 -0

Customize query in gerrit

Related Objects

Mentioned In: rEWBI3282c13f7ab0: Add basic custom DiffVisualizer
rEWBI3903539cb827: Add basic custom DiffVisualizer
rEWBI38c9b0c8f76b: Add basic custom DiffVisualizer
rEWBIb7781a7e0bf4: Add basic custom DiffVisualizer

Event Timeline

Jdforrester-WMF created this task.Jan 9 2019, 9:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2019, 9:44 PM

Basic patch incoming that will do this

Change 483293 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseMediaInfo@master] Add basic custom DiffVisualizer

https://gerrit.wikimedia.org/r/483293

gerritbot added a project: Patch-For-Review.Jan 9 2019, 10:02 PM

Addshore mentioned this in rEWBIb7781a7e0bf4: Add basic custom DiffVisualizer.Jan 9 2019, 10:05 PM

As this ticket also refers to the entity line I went and found that too.

It was caused by the default entity redirect diff, in wikibase normally we don't see this as there isn't a revision before the first one to compare the entity with to see this bit..

As media info entities don't have redirects we can just remove it from the visualization.

Patch updated

Addshore mentioned this in rEWBI38c9b0c8f76b: Add basic custom DiffVisualizer.Jan 9 2019, 10:14 PM

Wonderful, thank you.

Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 9 2019, 10:29 PM

Jdforrester-WMF mentioned this in rEWBI3903539cb827: Add basic custom DiffVisualizer.Jan 10 2019, 3:44 PM

Change 483293 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Add basic custom DiffVisualizer

https://gerrit.wikimedia.org/r/483293

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 10 2019, 5:00 PM

Jdforrester-WMF moved this task from Doing to Verify on Production on the Structured Data Engineering board.Jan 10 2019, 5:01 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF added a project: Multimedia-Team-Working-Board.Jan 11 2019, 10:24 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptJan 11 2019, 10:24 PM

Will be deployed next week (Test Commons on 2019-01-15, Real Commons on 2019-01-16).

Addshore moved this task from Unsorted 💣 to Closing ✔️ on the User-Addshore board.Jan 16 2019, 3:15 PM

Looks good to me

https://commons.wikimedia.org/w/index.php?title=File:Anoniem,_Antwerps_Uiltje,_KBS-FRB_01.jpg&diff=prev&oldid=336880257

jijiki mentioned this in rEWBI3282c13f7ab0: Add basic custom DiffVisualizer.Mar 18 2019, 4:26 PM

	F28071305: image.png
	Jan 29 2019, 8:41 AM

	F27836344: image.png
	Jan 9 2019, 10:09 PM

	F27836303: image.png
	Jan 9 2019, 10:01 PM

Create a custom Wikibase diff view for WBMI so that we can suppress the "entity" line, and use a different description for "caption" instead of "label"Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Create a custom Wikibase diff view for WBMI so that we can suppress the "entity" line, and use a different description for "caption" instead of "label"
Closed, ResolvedPublic
Actions