Page MenuHomePhabricator

Using "Image" generates a "div-span-flip" Lint error
Closed, ResolvedPublic

Description

https://www.mediawiki.org/wiki/Extension:Quiz generates Miscellaneous Tidy Replacement Issues with a div-span-flip lint error when Image (<code>{[[Image:]]...|type="{}"}</code>) is included in the quiz text.

For examples, see any of the /Quiz pages on https://en.wikiversity.org/wiki/Special:LintErrors/misc-tidy-replacement-issues.

Event Timeline

Aklapper renamed this task from Extension:Quiz Image Generates div-span-flip Lint Error to Using "Image" generates a "div-span-flip" Lint error.Jan 12 2019, 2:52 PM

Change 483992 had a related patch set uploaded (by Tacsipacsi; owner: Tacsipacsi):
[mediawiki/extensions/Quiz@master] Use <div> for question text instead of <span>

https://gerrit.wikimedia.org/r/483992

Tacsipacsi triaged this task as High priority.

Confirming that this issue is still present as of August 2020.

https://en.wikiversity.org/w/index.php?title=Charges/Interactions/Quiz&action=submit

The relevant line in the code being:

{[[Image:3D Vector.svg|100px|thumb|right]] For standard basis, or unit, vectors ('''i''', '''j''', '''k''') and vector components of '''a''' ('''a'''<sub>x</sub>, '''a'''<sub>y</sub>, '''a'''<sub>z</sub>), what are the right ascension, declination, and value of a?
|type="[]"}
- if the x-axis is the longitude of the Greenwich meridian, and '''a'''<sub>x</sub> equals '''a'''<sub>y</sub>, then RA equals 6<sup>h</sup>
+ if the x-axis is the longitude of the Greenwich meridian, and '''a'''<sub>x</sub> equals '''a'''<sub>y</sub>, then RA equals 3<sup>h</sup>
+ the value of '''a''' is given by <math>a = \sqrt{a^2_x + a^2_y + a^2_z}</math>
- if '''a'''<sub>x</sub> equals '''a'''<sub>y</sub> equals '''a'''<sub>z</sub>, then the declination is -45°
+ if '''a'''<sub>x</sub> equals '''a'''<sub>y</sub> equals '''a'''<sub>z</sub>, then the declination is +45°

I appreciate there was a patch submitted... but the last review on it was in April 2019.

@Aklapper I did so, I’m now waiting for @Mvolz’s answer.

Aklapper added a subscriber: Tacsipacsi.

@Tacsipacsi: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action...Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

I do plan working on it, as I’ve already stated on October 20.

Change #483992 merged by jenkins-bot:

[mediawiki/extensions/Quiz@master] Use <div> for question text instead of <span>

https://gerrit.wikimedia.org/r/483992

Patch merged, lint error list mentioned in description empty, page chosen at random https://en.wikiversity.org/wiki/Electric_Circuit_Analysis/Circuit_Analysis_Quiz_1 looks good, I think we can call this done. Sorry for not following up on the merge earlier.