Page MenuHomePhabricator

Takedown Tools: Software hangs on image upload, does not submit to NCMEC at all
Closed, ResolvedPublic3 Estimated Story Points

Description

I had to file two reports this week and neither actually reached NCMEC. Both hung on the actual image upload. It does submit at least *some* data to NCMEC, since we get a seemingly valid case number from them, but it just bounces back from their system as an incomplete report.

As an aside, NCMEC's own CyberTip system is much easier to use than it perhaps used to be, so using this instead may actually be a viable option now.

Event Timeline

jrbs triaged this task as High priority.Jan 16 2019, 7:33 PM
jrbs created this task.
jrbs renamed this task from Software hangs on image upload, does not submit to NCMEC at all to Takedown Tools: Software hangs on image upload, does not submit to NCMEC at all.Jan 16 2019, 7:33 PM

This is the two most-recent submissions on the tool, btw (numbers 157 and 158). I haven't yet received a bounceback from 158, but since the upload box glowed an ominous red I'd be surprised if it actually submitted.

TBolliger set the point value for this task to 3.Jan 16 2019, 7:50 PM

Just got my bounceback from 158. I can't paste it here for privacy reasons.

@jrbs how large where the files you were attempting to upload?

I’m not sure exactly but 158 was a pretty large file for sure. The files are obviously not very easily accessible now to check.

I tested a large (6.2 MB) file (locally) and got this error in the logs:

ingress_1   | 2019/01/21 17:07:14 [error] 6#6: *8 client intended to send too large body: 5228609 bytes, client: 172.19.0.1, server: localhost, request: "POST /api/takedown/15/ncmec/file/8 HTTP/1.1", host: "127.0.0.1:8888", referrer: "http://127.0.0.1:8888/takedown/create"

I increased the upload limit from 2MB to 64MB and then I was able to upload the large file.

https://github.com/wikimedia/takedown-tools/pull/13

I increased the upload limit from 2MB to 64MB and then I was able to upload the large file.

That might do it. I'll see if it does the job next time we need to submit to NCMEC.

jrbs lowered the priority of this task from High to Low.Jan 22 2019, 4:48 PM

(changing priority in lieu of just resolving)

dbarratt raised the priority of this task from Low to High.Jan 22 2019, 5:09 PM

This hasn't been merged / deployed yet (I wont be able to until the VPN starts working again).

This hasn't been merged / deployed yet (I wont be able to until the VPN starts working again).

ah, apologies :D

Just got access to the VPN, and sure enough:

ingress_1   | 2019-01-15T22:46:56.628586891Z 2019/01/15 22:46:56 [error] 6#6: *137 client intended to send too large body: 1863932 bytes, client: 172.21.0.4, server: localhost, request: "POST /api/takedown/158/ncmec/file/51 HTTP/1.1", host: "lcatools.corp.wikimedia.org", referrer: "https://lcatools.corp.wikimedia.org/takedown/create"
dbarratt moved this task from Review to Done on the Anti-Harassment (Bet — ב) board.
$ docker-compose exec api php -i | grep 'post_max_size'
post_max_size => 64M => 64M
$ docker-compose exec api php -i | grep 'upload_max_filesize'
upload_max_filesize => 64M => 64M

@jrbs I'm going to close this issue for now, but please reopen if you experience the same problem again.