Page MenuHomePhabricator
Create Task
Maniphest T214107

createcollaborationhub/list form input alignment issues
Closed, ResolvedPublic
Actions

Description

  • no-js version: elements have weird offset
  • js: also offset issues, but different

Details

SubjectRepoBranchLines +/-
SpecialCreateCollaborationHub: Use complex title widget to fix alignment issues and totally redo entire page to work around itmediawiki/extensions/CollaborationKitmaster+349 -201
Fix alignment and label formatting on Special:CreateHubFeaturemediawiki/extensions/CollaborationKitmaster+15 -30
Customize query in gerrit

Related Objects

Event Timeline

Isarra created this task.Jan 17 2019, 10:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2019, 10:53 PM
Isarra added a comment.Feb 20 2019, 2:19 PM

Apparently some similar issues on createhubfeature.

gerritbot subscribed.Feb 20 2019, 3:41 PM

Change 491781 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/extensions/CollaborationKit@master] Fix alignment and label formatting on Special:CreateHubFeature

https://gerrit.wikimedia.org/r/491781

gerritbot added a project: Patch-For-Review.Feb 20 2019, 3:41 PM
Isarra added a comment.Feb 20 2019, 3:47 PM

Forms to check:

  • hub content editor
  • list content editor
  • specialcreatecollaborationhub
  • specialcreatehubfeature
Isarra mentioned this in rECKT18252e46ef15: Fix alignment and label formatting on Special:CreateHubFeature.Feb 20 2019, 3:48 PM
Isarra mentioned this in rECKTf1fd613cedf6: Fix alignment and label formatting on Special:CreateHubFeature.Feb 20 2019, 3:53 PM
gerritbot added a comment.Feb 28 2019, 4:28 PM

Change 491781 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Fix alignment and label formatting on Special:CreateHubFeature

https://gerrit.wikimedia.org/r/491781

Isarra added a comment.Apr 9 2019, 11:50 PM

Well, this is apparently now worse than previously. Um.

Isarra removed a project: Patch-For-Review.Apr 10 2019, 4:43 PM
gerritbot added a comment.May 9 2019, 4:30 PM

Change 509107 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/extensions/CollaborationKit@master] SpecialCreateCollaborationHub: Fix alignment of complex title input and totally redo entire page to work around it

https://gerrit.wikimedia.org/r/509107

gerritbot added a project: Patch-For-Review.May 9 2019, 4:30 PM
Isarra mentioned this in rECKTbbdeec915b0f: SpecialCreateCollaborationHub: Fix alignment of complex title input and totally….May 9 2019, 4:41 PM
ashley mentioned this in rECKT473ee487dfdd: SpecialCreateCollaborationHub: Fix alignment of complex title input and totally….May 9 2019, 5:04 PM
Isarra mentioned this in rECKT8b7594a1f620: SpecialCreateCollaborationHub: Use complex title widget to fix alignment issues….May 10 2019, 6:59 PM
Isarra mentioned this in rECKTb22ec1bdb245: SpecialCreateCollaborationHub: Use complex title widget to fix alignment issues….May 10 2019, 7:10 PM
gerritbot added a comment.May 10 2019, 9:54 PM

Change 509107 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] SpecialCreateCollaborationHub: Use complex title widget to fix alignment issues and totally redo entire page to work around it

https://gerrit.wikimedia.org/r/509107

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 1:38 PM
Isarra closed this task as Resolved.Sep 12 2019, 10:54 PM
Isarra claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL