Page MenuHomePhabricator

Not Valid W3C HTML in TimelessTemplate.php
Closed, ResolvedPublic

Description

  1. Element div class "pokey" not allowed as child of element h2 in this context.
  2. Attribute redundant not allowed on element a at this point.

Steps to reproduce: https://validator.w3.org/nu/?doc=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FWikimania%3Fuseskin%3DTimeless

From https://www.mediawiki.org/wiki/Skin_talk:Timeless#Not_Valid_W3C_HTML :

Аlso a problem not directly related to this skin
In /includes/skins/SkinTemplate.php
"$content_navigation['views']['view']['redundant'] = true;"
add not valid parameter in tag <a> "redundant"
if set "false" and comment class "pokey", code in THML is a clean!
if comment these valuess of the code will cause my site to malfunction?

Event Timeline

Isarra created this task.Jan 18 2019, 8:57 PM

Change 530378 had a related patch set uploaded (by Simon04; owner: Simon04):
[mediawiki/skins/Timeless@master] Drop redundant attribute from a elements

https://gerrit.wikimedia.org/r/530378

Change 530610 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/core@master] Remove 'redundant' attribute from BaseTemplate::makeListItem() links in case this is not done in SkinTemplate::buildContentActionUrls()

https://gerrit.wikimedia.org/r/530610

Isarra closed this task as Resolved.Aug 16 2019, 5:10 PM
Isarra claimed this task.

\o/

Change 530378 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Drop redundant attribute from a elements

https://gerrit.wikimedia.org/r/530378

Change 530610 merged by jenkins-bot:
[mediawiki/core@master] Remove 'redundant' attribute from BaseTemplate::makeListItem() links in case this is not done in SkinTemplate::buildContentActionUrls()

https://gerrit.wikimedia.org/r/530610