Page MenuHomePhabricator
Create Task
Maniphest T214202

Not Valid W3C HTML in TimelessTemplate.php
Closed, ResolvedPublic
Actions

Description

  1. Element div class "pokey" not allowed as child of element h2 in this context.
  2. Attribute redundant not allowed on element a at this point.

Steps to reproduce: https://validator.w3.org/nu/?doc=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FWikimania%3Fuseskin%3DTimeless

From https://www.mediawiki.org/wiki/Skin_talk:Timeless#Not_Valid_W3C_HTML :

Аlso a problem not directly related to this skin
In /includes/skins/SkinTemplate.php
"$content_navigation['views']['view']['redundant'] = true;"
add not valid parameter in tag <a> "redundant"
if set "false" and comment class "pokey", code in THML is a clean!
if comment these valuess of the code will cause my site to malfunction?

Details

SubjectRepoBranchLines +/-
Remove 'redundant' attribute from BaseTemplate::makeListItem() links in case this is not done in SkinTemplate::buildContentActionUrls()mediawiki/coremaster+4 -0
Drop `redundant` attribute from `a` elementsmediawiki/skins/Timelessmaster+12 -0
Customize query in gerrit

Related Objects

Event Timeline

Isarra created this task.Jan 18 2019, 8:57 PM
simon04 updated the task description. (Show Details)Aug 15 2019, 2:14 PM
simon04 subscribed.

div.pokey fixed via https://gerrit.wikimedia.org/r/c/mediawiki/skins/Timeless/+/525424

gerritbot added a comment.Aug 15 2019, 2:17 PM

Change 530378 had a related patch set uploaded (by Simon04; owner: Simon04):
[mediawiki/skins/Timeless@master] Drop redundant attribute from a elements

https://gerrit.wikimedia.org/r/530378

gerritbot added a project: Patch-For-Review.Aug 15 2019, 2:17 PM
gerritbot added a comment.Aug 16 2019, 4:59 PM

Change 530610 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/core@master] Remove 'redundant' attribute from BaseTemplate::makeListItem() links in case this is not done in SkinTemplate::buildContentActionUrls()

https://gerrit.wikimedia.org/r/530610

Isarra closed this task as Resolved.Aug 16 2019, 5:10 PM
Isarra claimed this task.

\o/

gerritbot added a comment.Aug 16 2019, 5:15 PM

Change 530378 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Drop redundant attribute from a elements

https://gerrit.wikimedia.org/r/530378

Restricted Repository Identity mentioned this in rSKIN0eb03345858e: Update git submodules.Aug 16 2019, 5:17 PM
gerritbot added a comment.Aug 19 2019, 2:10 PM

Change 530610 merged by jenkins-bot:
[mediawiki/core@master] Remove 'redundant' attribute from BaseTemplate::makeListItem() links in case this is not done in SkinTemplate::buildContentActionUrls()

https://gerrit.wikimedia.org/r/530610

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2019, 3:10 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 9:01 PM
Reedy mentioned this in T295411: PHP Exception. Error: Cannot unset string offsets includes/skins/Skin.php(2472): unset( $item['redundant'] );.Nov 9 2021, 10:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits