AbuseFilterViewList.php: PHP Notice: compact(): Undefined variable: querypattern
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Paladox
	Jan 20 2019, 7:30 PM

Description

Hi, im getting this on 1.32

ErrorException from line 137 of /srv/mediawiki/w/extensions/AbuseFilter/includes/Views/AbuseFilterViewList.php: PHP Notice: compact(): Undefined variable: querypattern
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/w/extensions/AbuseFilter/includes/Views/AbuseFilterViewList.php(137): compact(string, string, string, string, string, string)
#2 /srv/mediawiki/w/extensions/AbuseFilter/includes/special/SpecialAbuseFilter.php(122): AbuseFilterViewList->show()
#3 /srv/mediawiki/w/includes/specialpage/SpecialPage.php(569): SpecialAbuseFilter->execute(NULL)
#4 /srv/mediawiki/w/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL)
#5 /srv/mediawiki/w/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#6 /srv/mediawiki/w/includes/MediaWiki.php(860): MediaWiki->performRequest()
#7 /srv/mediawiki/w/includes/MediaWiki.php(517): MediaWiki->main()
#8 /srv/mediawiki/w/index.php(42): MediaWiki->run()
#9 {main}

PHP Notice:  compact(): Undefined variable: searchmode in /srv/mediawiki/w/extensions/AbuseFilter/includes/Views/AbuseFilterViewList.php on line 137

Details

Subject	Repo	Branch	Lines +/-
Avoid PHP 7.3 Undeclared variable notice	mediawiki/extensions/AbuseFilter	REL1_31	+6 -10
Avoid PHP 7.3 Undeclared variable notice	mediawiki/extensions/AbuseFilter	REL1_32	+6 -10
Avoid PHP 7.3 Undeclared variable notice	mediawiki/extensions/AbuseFilter	master	+6 -10

Customize query in gerrit

Event Timeline

Paladox created this task.Jan 20 2019, 7:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2019, 7:30 PM

Paladox updated the task description. (Show Details)Jan 20 2019, 7:36 PM

Change 485663 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Avoid PHP 7.3 Undeclared variable notice

https://gerrit.wikimedia.org/r/485663

gerritbot added a project: Patch-For-Review.Jan 21 2019, 2:35 PM

Daimona claimed this task.Jan 21 2019, 2:36 PM

Change 485663 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Avoid PHP 7.3 Undeclared variable notice

https://gerrit.wikimedia.org/r/485663

Daimona closed this task as Resolved.Jan 31 2019, 9:55 PM

Daimona removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 31 2019, 10:00 PM

Change 487449 had a related patch set uploaded (by Paladox; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@REL1_32] Avoid PHP 7.3 Undeclared variable notice

https://gerrit.wikimedia.org/r/487449

Change 487450 had a related patch set uploaded (by Paladox; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@REL1_31] Avoid PHP 7.3 Undeclared variable notice

https://gerrit.wikimedia.org/r/487450

Change 487449 merged by Daimona Eaytoy:
[mediawiki/extensions/AbuseFilter@REL1_32] Avoid PHP 7.3 Undeclared variable notice