Page MenuHomePhabricator
Create Task
Maniphest T215123

Remove setMethod( 'post' ) from HTMLForm Object
Closed, ResolvedPublic
Actions

Description

Per HTMLForm.php, The default form method is post. So remove setMethod which have post parameter.

Details

SubjectRepoBranchLines +/-
Remove setMethod( 'post' ) from HTMLForm Objectmediawiki/extensions/TemplateSandboxmaster+0 -1
Remove setMethod( 'post' ) from HTMLForm Objectmediawiki/extensions/UserPageViewTrackermaster+0 -1
Remove setMethod( 'post' ) from HTMLForm Objectmediawiki/extensions/Nukemaster+0 -1
Remove setMethod( 'post' ) from HTMLForm Objectmediawiki/coremaster+0 -2
Remove setMethod( 'post' ) from HTMLForm Objectmediawiki/extensions/Cargomaster+0 -2
Remove setMethod( 'post' ) from HTMLForm Objectmediawiki/extensions/UserExportmaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

Jayprakash12345 created this task.Feb 3 2019, 2:36 PM
Restricted Application added a project: User-Jayprakash12345. · View Herald TranscriptFeb 3 2019, 2:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Feb 3 2019, 2:43 PM

Change 487654 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/UserExport@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/487654

gerritbot added a project: Patch-For-Review.Feb 3 2019, 2:43 PM
gerritbot added a comment.Feb 3 2019, 2:50 PM

Change 487655 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/Cargo@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/487655

gerritbot added a comment.Feb 4 2019, 9:54 PM

Change 487654 merged by jenkins-bot:
[mediawiki/extensions/UserExport@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/487654

gerritbot added a comment.Feb 4 2019, 9:56 PM

Change 487655 merged by jenkins-bot:
[mediawiki/extensions/Cargo@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/487655

Aklapper renamed this task from Remove setMethod( 'post' ) from HTMLForm Object to [UserExport] Remove setMethod( 'post' ) from HTMLForm Object.Feb 23 2019, 6:04 AM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 1:37 PM
Jayprakash12345 renamed this task from [UserExport] Remove setMethod( 'post' ) from HTMLForm Object to Remove setMethod( 'post' ) from HTMLForm Object.Jan 1 2020, 7:27 PM
gerritbot added a comment.Jan 1 2020, 7:29 PM

Change 561361 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/core@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/561361

gerritbot added a project: Patch-For-Review.Jan 1 2020, 7:29 PM
gerritbot added a comment.Jan 1 2020, 7:38 PM

Change 561362 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/UserPageViewTracker@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/561362

gerritbot added a comment.Jan 1 2020, 7:49 PM

Change 561363 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/Nuke@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/561363

gerritbot added a comment.Jan 1 2020, 7:58 PM

Change 561364 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/TemplateSandbox@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/561364

gerritbot added a comment.Jan 1 2020, 11:25 PM

Change 561361 merged by jenkins-bot:
[mediawiki/core@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/561361

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Jan 2 2020, 12:00 AM
Anomie subscribed.Jan 2 2020, 5:31 PM

Why bother? It doesn't hurt anything to set the default.

gerritbot added a comment.Jan 6 2020, 5:21 PM

Change 561363 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/561363

gerritbot added a comment.Mar 5 2020, 2:10 AM

Change 561362 merged by jenkins-bot:
[mediawiki/extensions/UserPageViewTracker@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/561362

gerritbot added a comment.Mar 5 2020, 2:15 AM

Change 561364 merged by jenkins-bot:
[mediawiki/extensions/TemplateSandbox@master] Remove setMethod( 'post' ) from HTMLForm Object

https://gerrit.wikimedia.org/r/561364

Restricted Repository Identity mentioned this in rETSA4f3dac5d1f56: Remove setMethod( 'post' ) from HTMLForm Object.Mar 5 2020, 2:18 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.24; 2020-03-17); removed MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Mar 5 2020, 3:01 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 5 2020, 3:10 AM
Volker_E closed this task as Resolved.Mar 5 2020, 4:23 AM
Volker_E subscribed.

Thanks @Jayprakash12345!

Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 3:00 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits