Page MenuHomePhabricator
Create Task
Maniphest T215683

Debian Stretch lighttpd does not allow overriding existing mimetype.assign values
Open, Stalled, LowPublic
Actions

Description

Lighttpd 1.4.40 made overriding keys in an existing array a hard error. The Stretch version of lighttpd is 1.4.45. This change in the upstream application makes the advice at https://wikitech.wikimedia.org/wiki/Help:Toolforge/Web/Lighttpd#Header,_mimetype,_character_encoding,_error_handler for replacing existing mime-type mappings with new local versions obsolete.

Prior to Debian I set the txt files on betacommand-dev to "".txt" => "text/plain;charset=UTF-8"," while the default config is '".txt" => "text/plain",'

This creates an issue with some UTF-8 files as web browsers render it as "Western" encoding

"Jean_Prouvé_(1981).jpg" is rendered as "Jean_Prouvé_(1981).jpg" See this report: https://tools.wmflabs.org/betacommand-dev/reports/Multichill_files.txt

This is an issue with Debian because I can no longer override the default setting, instead I get an error message about having a duplicate key.

Details

SubjectRepoBranchLines +/-
Set custom mime-typesoperations/software/tools-webservicemaster+551 -1
Customize query in gerrit

Related Objects

Event Timeline

Betacommand created this task.Feb 9 2019, 1:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2019, 1:35 AM
Betacommand updated the task description. (Show Details)Feb 9 2019, 1:36 AM
• bd808 subscribed.Feb 9 2019, 7:49 PM

Related: T178601: Add charset=utf-8 by default to lighttpd

Reedy renamed this task from Debian Stretch lighttpd issue with txt file encoiding to Debian Stretch lighttpd issue with txt file encoding.Feb 9 2019, 8:37 PM
• bd808 renamed this task from Debian Stretch lighttpd issue with txt file encoding to Debian Stretch lighttpd does not allow overriding existing mimetype.assign values.Feb 9 2019, 8:47 PM
• bd808 updated the task description. (Show Details)
gerritbot subscribed.Feb 9 2019, 9:32 PM

Change 489409 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[operations/software/tools-webservice@master] Set custom mime-types

https://gerrit.wikimedia.org/r/489409

gerritbot added a project: Patch-For-Review.Feb 9 2019, 9:32 PM
gerritbot added a comment.Feb 20 2019, 11:09 PM

Change 489409 merged by jenkins-bot:
[operations/software/tools-webservice@master] Set custom mime-types

https://gerrit.wikimedia.org/r/489409

Stashbot mentioned this in T178601: Add charset=utf-8 by default to lighttpd.Feb 20 2019, 11:17 PM
Stashbot mentioned this in T193646: Can't access /mnt from kubernetes nodejs shell.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-cloud) [2019-02-20T23:17:29Z] <zhuyifei1999_> begin build new tools-webservice package T178601 T193646 T215683

Stashbot added a comment.Feb 20 2019, 11:30 PM

Mentioned in SAL (#wikimedia-cloud) [2019-02-20T23:30:52Z] <zhuyifei1999_> begin rebuilding all docker images T178601 T193646 T215683

• bd808 changed the task status from Open to Stalled.Feb 21 2019, 1:09 AM
• bd808 triaged this task as Lowest priority.
• bd808 edited projects, added Upstream; removed Patch-For-Review.

This is an upstream change, but we have now completed T178601: Add charset=utf-8 by default to lighttpd which at least tries to set some sane character encodings by default.

• bd808 mentioned this in T218060: Webservice for tool 'persondata' does not terminate / does not start.Mar 11 2019, 10:52 PM
• GTirloni added a project: cloud-services-team (Kanban).Mar 24 2019, 12:05 PM
• bd808 moved this task from Inbox to Blocked on the cloud-services-team (Kanban) board.Sep 12 2019, 9:16 PM
• Bstorm moved this task from Blocked to Graveyard on the cloud-services-team (Kanban) board.Dec 18 2019, 4:21 PM
gstrauss-wiki subscribed.Aug 9 2022, 9:17 AM

lighttpd.conf has allowed overridding values since lighttpd 1.4.46, released Oct 2017. e.g. mimetype.assign := ...

fnegri edited projects, added cloud-services-team; removed cloud-services-team (Kanban).Jan 18 2023, 6:53 PM
fnegri moved this task from Kanban to Graveyard on the cloud-services-team board.
fnegri raised the priority of this task from Lowest to Low.Sep 5 2024, 10:26 AM
gstrauss-wiki added a comment.Sep 5 2024, 6:24 PM

Why is this still open? Debian Stretch is EOL.

https://wikitech.wikimedia.org/wiki/Help:Toolforge/Web/Lighttpd#Header,_mimetype,_character_encoding,_error_handler also looks to have been updated to use mimetype.assign := ...

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits