[Extension:Duplicator] Remove the usage of global variable $wgUser, $wgRequest, $wgOut, $wgLang
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jayprakash12345
	Feb 18 2019, 10:16 AM

Description

Problem

Now we are replacing the global variable by getting the context. The Classes which extends SpecialPage can directly access the context by $this.

Solution

Replace

$wgUser with $this->getUser()
$wgRequest with $this->getRequest()
$wgOut with $this->getOutput()
$wgLang with $this->getLanguage()

in Duplicator.page.php. If there are multiple usages then use a variable to store context instead of calling $this again and again.

Level

Easy

Reserved for Mini-MWT at VVIT (Feb 2019)

Details

	Subject	Repo	Branch	Lines +/-
	added Remove the usage of global variable $wgUser, $wgRequest, $wgOut, $wgLang	mediawiki/extensions/Duplicator	master	+22 -20

Customize query in gerrit

Event Timeline

Jayprakash12345 created this task.Feb 18 2019, 10:16 AM

Restricted Application added a project: User-Jayprakash12345. · View Herald TranscriptFeb 18 2019, 10:16 AM

Jayprakash12345 moved this task from General coordination to Task for Students on the Mini-MWT at VVIT (Feb 2019) board.Feb 18 2019, 10:16 AM

Jayprakash12345 removed a project: User-Jayprakash12345.

Liuxinyu970226 added a project: MediaWiki-extensions-Other.Feb 22 2019, 5:49 AM

Liuxinyu970226 added a subscriber: VitaliyFilippov.

MNavya claimed this task.Feb 23 2019, 5:42 AM

Change 492446 had a related patch set uploaded (by MNavya; owner: MNavya):
[mediawiki/extensions/Duplicator@master] added Remove the usage of global variable $wgUser, $wgRequest, $wgOut, $wgLang

https://gerrit.wikimedia.org/r/492446

gerritbot added a project: Patch-For-Review.Feb 23 2019, 6:46 AM

Peachey88 edited projects, added MediaWiki-extensions-Duplicator; removed MediaWiki-extensions-Other.Mar 17 2019, 4:56 AM

Hi @MNavya: Do you still work on this task? Could you maybe share an update? Do you still plan to work on this task, or do you need any help?

If you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action... → Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)

Without respond in previous 24 days, I've made https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Duplicator/+/651811 for things which are left do to from this task, so I'm assigning this to myself.

Restricted Application added a project: User-Kizule. · View Herald TranscriptDec 23 2020, 6:06 PM

Kizule moved this task from Inbox to To deploy on the User-Kizule board.Dec 23 2020, 6:06 PM

Done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Duplicator/+/651811

@Reedy Can you abandon https://gerrit.wikimedia.org/r/c/492446 please?

[Extension:Duplicator] Remove the usage of global variable $wgUser, $wgRequest, $wgOut, $wgLangClosed, ResolvedPublicActions