Page MenuHomePhabricator

[Extension:Duplicator] Remove the usage of global variable $wgUser, $wgRequest, $wgOut, $wgLang
Open, Needs TriagePublic

Description

Problem

Now we are replacing the global variable by getting the context. The Classes which extends SpecialPage can directly access the context by $this.

Solution

Replace

  1. $wgUser with $this->getUser()
  2. $wgRequest with $this->getRequest()
  3. $wgOut with $this->getOutput()
  4. $wgLang with $this->getLanguage()

in Duplicator.page.php. If there are multiple usages then use a variable to store context instead of calling $this again and again.

Level

Easy

Reserved for Mini-MWT at VVIT (Feb 2019)

Event Timeline

Change 492446 had a related patch set uploaded (by MNavya; owner: MNavya):
[mediawiki/extensions/Duplicator@master] added Remove the usage of global variable $wgUser, $wgRequest, $wgOut, $wgLang

https://gerrit.wikimedia.org/r/492446

Hi @MNavya: Do you still work on this task? Could you maybe share an update? Do you still plan to work on this task, or do you need any help?

If you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action...Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)

Kizule added a subscriber: MNavya.

Without respond in previous 24 days, I've made https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Duplicator/+/651811 for things which are left do to from this task, so I'm assigning this to myself.