Page MenuHomePhabricator
Create Task
Maniphest T216429

CirrusSearch should provide a query dispatcher
Closed, ResolvedPublic
Actions

Description

Extensions may define their own query builders. CirrusSearch should provide a Query dispatcher that extensions could configure to let cirrus decide which query builders to trigger for a given SearchQuery.

Details

SubjectRepoBranchLines +/-
Remove CirrusSearchFulltextQueryBuilder[Complete] hooksmediawiki/extensions/CirrusSearchmaster+0 -23
Use CirrusSearch query dispatch servicemediawiki/extensions/WikibaseCirrusSearchmaster+127 -591
Revert "Revert "[cirrus] Use correct factory declaration for EntityFullTextQueryBuilder""operations/mediawiki-configmaster+1 -1
Support new factory_method format in query builder profilemediawiki/extensions/WikibaseCirrusSearchmaster+22 -7
[cirrus] Use correct factory declaration for EntityFullTextQueryBuilderoperations/mediawiki-configmaster+1 -1
Allow Querybuilder instances to be built using ObjectFactorymediawiki/extensions/CirrusSearchmaster+85 -10
Add a search query dispatch servicemediawiki/extensions/CirrusSearchmaster+678 -0
Add constants for SearchEngine entry pointsmediawiki/extensions/CirrusSearchmaster+24 -6
Customize query in gerrit

Related Objects

Event Timeline

dcausse created this task.Feb 18 2019, 6:08 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptFeb 18 2019, 6:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dcausse triaged this task as Medium priority.Feb 18 2019, 6:08 PM
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
gerritbot subscribed.Feb 20 2019, 6:04 PM

Change 491814 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add constants for SearchEngine entry points

https://gerrit.wikimedia.org/r/491814

gerritbot added a project: Patch-For-Review.Feb 20 2019, 6:04 PM

Change 491815 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] [WIP] Add search query dispatch service

https://gerrit.wikimedia.org/r/491815

gerritbot added a comment.Feb 20 2019, 7:03 PM

Change 491814 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add constants for SearchEngine entry points

https://gerrit.wikimedia.org/r/491814

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Feb 20 2019, 8:00 PM
gerritbot added a comment.Feb 21 2019, 6:13 PM

Change 492012 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/WikibaseCirrusSearch@master] [WIP] Use CirrusSearch query dispatch service

https://gerrit.wikimedia.org/r/492012

dcausse mentioned this in rEWCS37eed555c83d: [WIP] Use CirrusSearch query dispatch service.Feb 21 2019, 6:21 PM
dcausse mentioned this in rEWCS34806fb6aeee: [WIP] Use CirrusSearch query dispatch service.
dcausse mentioned this in rEWCS2598af590a20: [WIP] Use CirrusSearch query dispatch service.Feb 21 2019, 6:37 PM
EBernhardson moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Feb 22 2019, 7:17 PM
dcausse moved this task from Needs review to Incoming on the Discovery-Search (Current work) board.Mar 12 2019, 5:41 PM
dcausse moved this task from Incoming to Waiting on the Discovery-Search (Current work) board.Mar 19 2019, 3:59 PM
dcausse added a comment.Mar 19 2019, 4:50 PM

Being discussed https://www.mediawiki.org/wiki/Extension:CirrusSearch/Query_Construction/Use_cases

dcausse moved this task from Waiting to Incoming on the Discovery-Search (Current work) board.May 29 2019, 9:50 AM
gerritbot added a comment.Jun 4 2019, 3:11 PM

Change 491815 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add a search query dispatch service

https://gerrit.wikimedia.org/r/491815

gerritbot added a comment.Jun 4 2019, 4:48 PM

Change 492012 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/WikibaseCirrusSearch@master] Use CirrusSearch query dispatch service

https://gerrit.wikimedia.org/r/492012

dcausse mentioned this in rEWCScc70280fc686: Use CirrusSearch query dispatch service.Jun 4 2019, 4:50 PM
dcausse mentioned this in rEWCS51be0dc1eb1f: [WIP] Use CirrusSearch query dispatch service.Jun 4 2019, 5:00 PM
gerritbot added a comment.Jun 5 2019, 12:42 AM

Change 491815 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add a search query dispatch service

https://gerrit.wikimedia.org/r/491815

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 5 2019, 1:00 AM
gerritbot added a comment.Jun 12 2019, 2:54 PM

Change 516637 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Allow Querybuilder instances to be built using ObjectFactory

https://gerrit.wikimedia.org/r/516637

gerritbot added a comment.Jun 13 2019, 8:55 AM

Change 516750 had a related patch set uploaded (by DCausse; owner: DCausse):
[operations/mediawiki-config@master] [cirrus] Use correct factory declaration for EntityFullTextQueryBuilder

https://gerrit.wikimedia.org/r/516750

dcausse mentioned this in rEWCS76c016fefa3f: Use CirrusSearch query dispatch service.Jun 13 2019, 1:38 PM
gerritbot added a comment.Jun 13 2019, 1:51 PM

Change 516777 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Remove CirrusSearchFulltextQueryBuilder[Complete] hooks

https://gerrit.wikimedia.org/r/516777

dcausse moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Jun 13 2019, 2:11 PM
dcausse mentioned this in rEWCSeac45e5a7898: Use CirrusSearch query dispatch service.Jun 17 2019, 1:14 PM
dcausse mentioned this in rEWCS2e32652a7114: Use CirrusSearch query dispatch service.Jun 17 2019, 3:26 PM
dcausse mentioned this in rEWCS5e0a53a30b03: Use CirrusSearch query dispatch service.Jun 19 2019, 2:04 PM
gerritbot added a comment.Jun 24 2019, 1:23 PM

Change 516637 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Allow Querybuilder instances to be built using ObjectFactory

https://gerrit.wikimedia.org/r/516637

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.11; 2019-06-26); removed MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 24 2019, 2:00 PM
dcausse mentioned this in rEWCSbecca9f6ebb4: Use CirrusSearch query dispatch service.Jun 24 2019, 2:58 PM
gerritbot added a comment.Jul 11 2019, 11:02 AM

Change 516750 merged by jenkins-bot:
[operations/mediawiki-config@master] [cirrus] Use correct factory declaration for EntityFullTextQueryBuilder

https://gerrit.wikimedia.org/r/516750

gerritbot added a comment.Jul 11 2019, 1:55 PM

Change 522093 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/WikibaseCirrusSearch@master] Support new factory_method format in query builder profile

https://gerrit.wikimedia.org/r/522093

gerritbot added a comment.Jul 11 2019, 1:55 PM

Change 522092 had a related patch set uploaded (by DCausse; owner: DCausse):
[operations/mediawiki-config@master] Revert "Revert "[cirrus] Use correct factory declaration for EntityFullTextQueryBuilder""

https://gerrit.wikimedia.org/r/522092

gerritbot added a comment.Jul 11 2019, 5:48 PM

Change 522093 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Support new factory_method format in query builder profile

https://gerrit.wikimedia.org/r/522093

dcausse mentioned this in rEWCSacee722d8943: Support new factory_method format in query builder profile.Jul 11 2019, 5:53 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.14; 2019-07-16); removed MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jul 11 2019, 6:00 PM
gerritbot added a comment.Jul 29 2019, 11:04 AM

Change 522092 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Revert "[cirrus] Use correct factory declaration for EntityFullTextQueryBuilder""

https://gerrit.wikimedia.org/r/522092

gerritbot added a comment.Jul 30 2019, 12:12 AM

Change 492012 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Use CirrusSearch query dispatch service

https://gerrit.wikimedia.org/r/492012

gerritbot added a comment.Jul 30 2019, 12:44 AM

Change 516777 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Remove CirrusSearchFulltextQueryBuilder[Complete] hooks

https://gerrit.wikimedia.org/r/516777

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.16; 2019-07-30); removed MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 30 2019, 1:00 AM
dcausse mentioned this in rEWCS0cd8339c8054: Use CirrusSearch query dispatch service.Jul 30 2019, 1:16 AM
dcausse moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jul 30 2019, 5:21 PM
debt closed this task as Resolved.Jul 30 2019, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits