Upgrade TorBlock extension to use newer phan
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Feb 24 2019, 7:29 AM

Description

TorBlock needs to be upgraded to a newer version of phan, our PHP static analysis tool. This brings in
over 2 years of upstream improvements and lots of bug fixes.

Please follow the instructions on how to migrate at https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Add_phan_to_a_MediaWiki_extension#Migrating_from_phan_0.8.0.

Please also set the Gerrit topic for all patches related to this effort with new-phan-plz.

Details

	Subject	Repo	Branch	Lines +/-
	Upgrade TorBlock to use a newer version of phan	mediawiki/extensions/TorBlock	master	+20 -20

Customize query in gerrit

Event Timeline

Legoktm added projects: MediaWiki-extensions-TorBlock, phan.Feb 24 2019, 7:29 AM

Legoktm subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2019, 7:29 AM

I'll try this one.

includes/TorExitNodes.php:199 PhanTypeArraySuspicious Suspicious array access to ?mixed|?string

Change 492564 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/TorBlock@master] WIP: Upgrade TorBlock to use a newer version of phan

https://gerrit.wikimedia.org/r/492564

gerritbot added a project: Patch-For-Review.Feb 24 2019, 7:43 PM

Change 492564 had a related patch set uploaded (by Legoktm; owner: MarcoAurelio):
[mediawiki/extensions/TorBlock@master] Upgrade TorBlock to use a newer version of phan

https://gerrit.wikimedia.org/r/492564

Change 492564 merged by jenkins-bot:
[mediawiki/extensions/TorBlock@master] Upgrade TorBlock to use a newer version of phan

https://gerrit.wikimedia.org/r/492564

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 5 2019, 3:01 PM

MarcoAurelio closed this task as Resolved.Apr 6 2019, 10:52 AM

MarcoAurelio claimed this task.

MarcoAurelio removed a project: Patch-For-Review.

Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptApr 6 2019, 10:52 AM

MarcoAurelio moved this task from unsorted/backlog to cabinet on the User-MarcoAurelio board.Apr 6 2019, 12:06 PM