| Esanders | |
| Feb 25 2019, 11:57 AM |
| F28284842: image.png | |
| Feb 25 2019, 10:18 PM |
| F28284839: image.png | |
| Feb 25 2019, 10:18 PM |
| F28282767: image.png | |
| Feb 25 2019, 6:38 PM |
| F28282764: image.png | |
| Feb 25 2019, 6:38 PM |
| F28281548: image.png | |
| Feb 25 2019, 11:57 AM |
Most widgets can still be read when disabled (e.g. checkboxes, radios, input widgets, dropdowns), but there is no distinct styling for a pressed+disabled buttons, so you can't tell which button in selected when the widget is disabled:
This is needed for VE's read-only mode where users should be able to inspect document state.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update OOUI to v0.30.4 | mediawiki/core | master | +1 K -1 K | |
| ButtonElement: Add styling for disabled active framed buttons | oojs/ui | master | +13 -0 |
Change 492746 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] Add styling for disabled active buttons
Ouch, read-only vs disabled, hmm? One immediate issue I see with just changing opacity– it fails on a contrast ratio level.
By the HTML spec, read-only is for inputs, and prevents you from changing the 'value' property. We are free to ignore this, but for most non-text widgets, readonly vs disabled would be the same.
it fails on a contrast ratio level.
@matmarex can you add "before" screenshots, to see if there are accessibility regressions?
I'm not sure what you mean, there was no styling for this mode before… the active button looked just like the other disabled buttons.
| Before | |
|---|---|
 |  |
I note that WikimediaUI theme disabled buttons don't meet AA or AAA contrast guidelines. My proposed styling for disabled active buttons doesn't meet them either (but it's closer).
Change 492746 merged by jenkins-bot:
[oojs/ui@master] ButtonElement: Add styling for disabled active framed buttons
Change 494883 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.4
