Page MenuHomePhabricator

site_tests.TestLogPages are failing for test_logpages and test_logpages_dump
Closed, ResolvedPublicBUG REPORT

Description

site_tests.TestLogPages are failing for test_logpages and test_logpages_dump on wikia family file
https://api.travis-ci.org/v3/job/501181525/log.txt

It is caused by 3a97ee5f199e2ff9fa07613d503863bdf22c8816

=================================== FAILURES ===================================
__________________________ TestLogPages.test_logpages __________________________

self = <tests.site_tests.TestLogPages testMethod=test_logpages>

    def test_logpages(self):
        """Test the deprecated site.logpages() method."""
        le = list(self.site.logpages(number=10))
>       self.assertOneDeprecation()

tests/site_tests.py:1348: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/aspects.py:1622: in assertOneDeprecation
    self.assertDeprecation(msg)
tests/aspects.py:1608: in assertDeprecation
    self.assertDeprecationFile(self.expect_warning_filename)
tests/aspects.py:1652: in assertDeprecationFile
    .format(filename, item))
E   AssertionError: expected warning filename /home/travis/build/wikimedia/pywikibot/tests/site_tests.py; warning item: {message : FutureWarning(u'set_namespace() will be modified to raise TypeError when namespace parameter is not supported. It will be a Breaking Change, please update your code ASAP, due date July, 31st 2019.',), category : 'FutureWarning', filename : '/home/travis/build/wikimedia/pywikibot/pywikibot/site.py', lineno : 4619, line : None}
------------------------------ Captured log call -------------------------------
logging.py                 109 WARNING  logevents module does not support a namespace parameter
_______________________ TestLogPages.test_logpages_dump ________________________

self = <tests.site_tests.TestLogPages testMethod=test_logpages_dump>

    def test_logpages_dump(self):
        """Test the deprecated site.logpages() method using dump mode."""
        le = list(self.site.logpages(number=10, dump=True))
>       self.assertOneDeprecation()

tests/site_tests.py:1375: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/aspects.py:1622: in assertOneDeprecation
    self.assertDeprecation(msg)
tests/aspects.py:1608: in assertDeprecation
    self.assertDeprecationFile(self.expect_warning_filename)
tests/aspects.py:1652: in assertDeprecationFile
    .format(filename, item))
E   AssertionError: expected warning filename /home/travis/build/wikimedia/pywikibot/tests/site_tests.py; warning item: {message : FutureWarning(u'set_namespace() will be modified to raise TypeError when namespace parameter is not supported. It will be a Breaking Change, please update your code ASAP, due date July, 31st 2019.',), category : 'FutureWarning', filename : '/home/travis/build/wikimedia/pywikibot/pywikibot/site.py', lineno : 4619, line : None}
------------------------------ Captured log call -------------------------------
logging.py                 109 WARNING  logevents module does not support a namespace parameter
=============================== warnings summary ===============================

Event Timeline

Xqt triaged this task as High priority.Mar 5 2019, 3:18 PM
Xqt updated the task description. (Show Details)

Change 497519 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Set optional parameter namespace to None in site.logpages

https://gerrit.wikimedia.org/r/497519

Xqt changed the subtype of this task from "Task" to "Bug Report".Mar 19 2019, 3:50 PM

Change 497519 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Set optional parameter namespace to None in site.logpages

https://gerrit.wikimedia.org/r/497519