Page MenuHomePhabricator

extract throttling filter form wdqs so that it can be reused in other projects
Closed, DeclinedPublic

Description

There was talks about throttling gerrit, which is also running in jetty. The same basic mechanism could be reused, so extracting this code to a separate project / jar might help code reuse.

Note that the current implementation might need to be generalized a bit to be usable outside of wdqs.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Smalyshev triaged this task as Medium priority.Mar 19 2019, 5:52 PM
Smalyshev subscribed.

I am a little surprised such generic library doesn't exist already - as throttling is pretty common thing people do - but if other projects can benefit from our code, by all means we should set it up as a library.

Can't see T218636 but I assume it has to do with recent Gerrit vandalism incident.

We've already implemented something similar for Gerrit. Making a general solution seems more work than addressing each use case separately.

There is a project to have a more generic throttling solution, but at a higher level.

sbassett moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 28 2020, 6:59 PM