Page MenuHomePhabricator
Create Task
Maniphest T218932

Keep elasticsearch crosscluster settings in puppet
Closed, ResolvedPublic
Actions

Description

When enabling cross cluster search to support multi-instance we had to run custom scripts to update cluster settings (ref T213150).
Our puppet repo is not yet aware of this configuration.

Details

SubjectRepoBranchLines +/-
icinga: cirrus settings check is Ok when file config is emptyoperations/puppetproduction+2 -0
icinga: correct cirrus settings file nameoperations/puppetproduction+7 -7
icinga: create and apply cirrus settings checkoperations/puppetproduction+249 -1
elasticsearch: add new attributeoperations/puppetproduction+25 -5
icinga: add remote cluster check for elasticoperations/puppetproduction+118 -5
icinga: add unit test for elastic config checkoperations/puppetproduction+66 -0
elasticsearch: config file for aligning puppet configoperations/puppetproduction+22 -0
Customize query in gerrit

Related Objects

Event Timeline

dcausse created this task.Mar 21 2019, 7:21 PM
Restricted Application edited projects, added Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptMar 21 2019, 7:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dcausse triaged this task as Medium priority.Mar 21 2019, 7:21 PM
dcausse moved this task from needs triage to Ops / SRE on the Discovery-Search board.
• Mathew.onipe claimed this task.Mar 22 2019, 11:46 AM
• Mathew.onipe edited projects, added Discovery-Search (Current work); removed Discovery-Search.
• Mathew.onipe added a comment.Apr 10 2019, 11:43 AM

Keeping these configurations in puppet via elasti config file will not happen now due to many constrains. We will continue as it is now and then create icinga checks to alert when the remote clusters or seeds are not what they are in elastic.

gerritbot added a comment.Apr 11 2019, 8:10 AM

Change 502950 had a related patch set uploaded (by Mathew.onipe; owner: Mathew.onipe):
[operations/puppet@production] icinga: add remote cluster check for elastic

https://gerrit.wikimedia.org/r/502950

gerritbot added a project: Patch-For-Review.Apr 11 2019, 8:10 AM
gerritbot added a comment.Apr 25 2019, 10:55 AM

Change 506378 had a related patch set uploaded (by Mathew.onipe; owner: Mathew.onipe):
[operations/puppet@production] elasticsearch: config file for aligning puppet config

https://gerrit.wikimedia.org/r/506378

gerritbot added a comment.Apr 29 2019, 3:51 PM

Change 507045 had a related patch set uploaded (by Mathew.onipe; owner: Mathew.onipe):
[operations/puppet@production] icinga: create and apply config check

https://gerrit.wikimedia.org/r/507045

EBernhardson moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Apr 30 2019, 5:30 PM
gerritbot added a comment.May 1 2019, 3:41 PM

Change 506378 abandoned by Mathew.onipe:
elasticsearch: config file for aligning puppet config

Reason:
merged here: https://gerrit.wikimedia.org/r/c/operations/puppet/ /507045

https://gerrit.wikimedia.org/r/506378

gerritbot added a comment.May 3 2019, 12:08 PM

Change 507950 had a related patch set uploaded (by Mathew.onipe; owner: Mathew.onipe):
[operations/puppet@production] elasticsearch: add new attribute

https://gerrit.wikimedia.org/r/507950

gerritbot added a comment.May 8 2019, 3:12 AM

Change 508742 had a related patch set uploaded (by Mathew.onipe; owner: Mathew.onipe):
[operations/puppet@production] icinga: add unit test for elastic config check

https://gerrit.wikimedia.org/r/508742

gerritbot added a comment.May 16 2019, 12:39 PM

Change 508742 abandoned by Mathew.onipe:
icinga: add unit test for elastic config check

https://gerrit.wikimedia.org/r/508742

gerritbot added a comment.May 16 2019, 12:41 PM

Change 502950 abandoned by Mathew.onipe:
icinga: add remote cluster check for elastic

https://gerrit.wikimedia.org/r/502950

gerritbot added a comment.May 22 2019, 8:32 AM

Change 507950 merged by Gehel:
[operations/puppet@production] elasticsearch: add new attribute

https://gerrit.wikimedia.org/r/507950

gerritbot added a comment.May 24 2019, 8:53 AM

Change 507045 merged by Gehel:
[operations/puppet@production] icinga: create and apply cirrus settings check

https://gerrit.wikimedia.org/r/507045

gerritbot added a comment.May 24 2019, 9:46 AM

Change 512340 had a related patch set uploaded (by Mathew.onipe; owner: Mathew.onipe):
[operations/puppet@production] icinga: correct cirrus settings file name

https://gerrit.wikimedia.org/r/512340

gerritbot added a comment.May 24 2019, 10:04 AM

Change 512340 merged by Gehel:
[operations/puppet@production] icinga: correct cirrus settings file name

https://gerrit.wikimedia.org/r/512340

gerritbot added a comment.May 24 2019, 11:33 AM

Change 512352 had a related patch set uploaded (by Mathew.onipe; owner: Mathew.onipe):
[operations/puppet@production] icinga: cirrus settings check is Ok when file config is empty

https://gerrit.wikimedia.org/r/512352

gerritbot added a comment.May 24 2019, 1:22 PM

Change 512352 merged by Gehel:
[operations/puppet@production] icinga: cirrus settings check is Ok when file config is empty

https://gerrit.wikimedia.org/r/512352

• Mathew.onipe moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.May 28 2019, 10:27 AM
debt closed this task as Resolved.May 28 2019, 11:48 PM
RKemper subscribed.EditedFeb 10 2022, 9:07 PM

Fixed false negative bug in the check script (it would never detect drift): https://phabricator.wikimedia.org/T301511#7702414

gerritbot added a comment.Feb 10 2022, 9:12 PM

Change 761721 had a related patch set uploaded (by Ryan Kemper; author: Ryan Kemper):

[operations/puppet@production] elastic: fix cirrus settings false negative

https://gerrit.wikimedia.org/r/761721

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits