Page MenuHomePhabricator
Create Task
Maniphest T219717

Framed thumbnails are not centered
Closed, ResolvedPublic
Actions

Description

Timeless refuses to center framed images. It will only show them on the left or right of the page.

To reproduce this issue, try

[[File:Example.jpg|thumb|center]]

or

[[File:Example.jpg|frame|center]]

Details

SubjectRepoBranchLines +/-
Properly center framed thumbnail imagesmediawiki/skins/Timelessmaster+3 -0
Customize query in gerrit

Event Timeline

Heddy10 created this task.Mar 30 2019, 10:05 PM
gerritbot added a comment.Mar 31 2019, 4:59 PM

Change 500238 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/skins/Timeless@master] Properly center framed thumbnail images

https://gerrit.wikimedia.org/r/500238

gerritbot added a project: Patch-For-Review.Mar 31 2019, 4:59 PM
ashley moved this task from Backlog to Bugs on the Timeless board.Mar 31 2019, 5:02 PM
gerritbot added a comment.Apr 4 2019, 2:58 PM

Change 500238 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Properly center framed thumbnail images

https://gerrit.wikimedia.org/r/500238

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 4 2019, 3:02 PM
Isarra closed this task as Resolved.Apr 9 2019, 5:09 PM
Isarra assigned this task to ashley.
Isarra subscribed.

Closing this, should deploy everywhere else thursday. Someone please reopen if it's not fixed then.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL