Page MenuHomePhabricator

LocalFile isMissing always returns true regardless of file stat
Open, Needs TriagePublic

Description

The function isMissing from LocalFile always returns false because of a typo on the body. Among other things, this causes extensions relying on the isMissing function to operate incorrectly. For example, Graphviz always recreates a new image when rendering a graph from the dot syntax.

I'll open a patch to fix this, but I would like some help/guidance on writing tests for it.

Event Timeline

Restricted Application added projects: Commons, Multimedia. · View Herald TranscriptApr 5 2019, 9:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 501808 had a related patch set uploaded (by Juan Osorio (Microsoft); owner: Juan Osorio (Microsoft)):
[mediawiki/core@master] Fixes LocalFile isMissing always returning true

https://gerrit.wikimedia.org/r/501808

Change 501808 merged by jenkins-bot:
[mediawiki/core@master] Fixes LocalFile isMissing always returning true

https://gerrit.wikimedia.org/r/501808

Reedy added a subscriber: Reedy.May 31 2019, 10:50 PM

Is this still open because of the tests not having yet been written?