Maniphest T220244

LocalFile isMissing always returns true regardless of file stat
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	osorio-juan-microsoft
	Apr 5 2019, 9:33 PM

Description

The function isMissing from LocalFile always returns false because of a typo on the body. Among other things, this causes extensions relying on the isMissing function to operate incorrectly. For example, Graphviz always recreates a new image when rendering a graph from the dot syntax.

I'll open a patch to fix this, but I would like some help/guidance on writing tests for it.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fixes LocalFile isMissing always returning true	mediawiki/core	master	+4 -1

Customize query in gerrit

Event Timeline

osorio-juan-microsoft created this task.Apr 5 2019, 9:33 PM

Restricted Application added projects: Commons, Multimedia. · View Herald TranscriptApr 5 2019, 9:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 501808 had a related patch set uploaded (by Juan Osorio (Microsoft); owner: Juan Osorio (Microsoft)):
[mediawiki/core@master] Fixes LocalFile isMissing always returning true

https://gerrit.wikimedia.org/r/501808

gerritbot added a project: Patch-For-Review.Apr 5 2019, 9:48 PM

Change 501808 merged by jenkins-bot:
[mediawiki/core@master] Fixes LocalFile isMissing always returning true

https://gerrit.wikimedia.org/r/501808

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 6 2019, 12:01 AM

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 10:23 AM

Is this still open because of the tests not having yet been written?