Page MenuHomePhabricator

The visual editor only broke part of the table
Closed, DeclinedPublic

Description

Long-time VisualEditor user User:Redfiona99 reported an unusual problem at https://www.mediawiki.org/wiki/Topic:Uxfryia35y49vpgg It was fixed here: https://en.wikipedia.org/w/index.php?title=Enrico_K%C3%B6lling&diff=891288451&oldid=891285857&diffmode=source

This is related to T138338: Users can delete bits of table formatting when editing {{Yes}} and {{No}} template transclusion, breaking the table and T124934: Inserting the English Wikipedia {{won}} template into a table cell using VisualEditor shows unnecessary code and similar feature requests.

The reason this edit might represent a "bug" rather than a "feature request" (to support templates that insert arbitrary table formatting codes) is that it only broke part of the table, instead of removing needed lines from all the affected table rows.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ssastry closed this task as Declined.EditedApr 8 2019, 3:21 PM
ssastry subscribed.

It only "broke part of the table" is part of the design of Parsoid's html -> wt conversion code to eliminate dirty diffs. By design, Parsoid tries to convert only those parts of the page that were edited and leave the rest untouched. The scenario is a bit more nuanced than that (it finds the smallest part of the page that it considers edited which may be a bit larger than what the human editor actually touched), but for all practical purposes, that is a good rule of thumb to remember.

So, in this case, the rest of the table remained unmodified. So, nothing to do for this scenario specifically. If there is, please feel free to reopen and update the task or file a separate task, as appropriate.