Page MenuHomePhabricator

sq.wikiquote.org shows different time when you're logged in and when you're logged out
Closed, ResolvedPublic

Description

*Problem*

As shown in the pictures below, sq.wikiquote.org shows different times when you're logged in and when you're logged out. And neither of them is right.

Logged in:

Logged out:

*Accepted criteria*

Show the correct time (depending on the timezone the time should be accurate) and if you're logged in or logged out that shouldn't matter, the time should be the same.

Details

Related Gerrit Patches:
operations/mediawiki-config : masterSet sqwikiquote $wgLocalTimezone

Event Timeline

Margott created this task.Apr 23 2019, 2:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2019, 2:08 PM
Reedy added a subscriber: Reedy.Apr 23 2019, 2:52 PM

What time is it supposed to show? The current time now?

Reedy renamed this task from [Bug] sq.wikiquote.org shows different time when you're logged in and when you're logged out to sq.wikiquote.org shows different time when you're logged in and when you're logged out.Apr 23 2019, 2:52 PM

Yes, the current time now. Im updating the description.

Margott updated the task description. (Show Details)Apr 23 2019, 3:20 PM
Margott updated the task description. (Show Details)
Margott updated the task description. (Show Details)
Klein updated the task description. (Show Details)Apr 23 2019, 3:27 PM
Reedy added a comment.Apr 23 2019, 3:28 PM

Yes, the current time now. Im updating the description.

Depending on how that's being implemented.. It's definitely never going to work for anonymous users

Margott triaged this task as Lowest priority.Apr 23 2019, 3:46 PM

I see, then lets make it to show the right time when we are logged in. Would be nice to show the right time because of the banners and quote of the day. Its around one hour early as far as I can understand, which is not a big deal. If its too much work from the team that has to work on this, then we can skip it for now.

Reedy added a comment.Apr 23 2019, 3:47 PM

I see, then lets make it to show the right time when we are logged in. Would be nice to show the right time because of the banners and quote of the day. Its around one hour early as far as I can understand, which is not a big deal. If its too much work from the team that has to work on this, then we can skip it for now.

How is it implemented?

If it's an hour early, that sounds like a timezone issue preference/wiki config issue

Reedy added a comment.Apr 23 2019, 3:52 PM

A quick look... sqwiki and sqwikinews have a timezone set of Europe/Berlin. Nothing for sqwikiquote. So it's in UTC...

Change 505804 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Set sqwikiquote $wgLocalTimezone

https://gerrit.wikimedia.org/r/505804

Yes, thats right. Thank you :)

Reedy added a comment.Apr 23 2019, 3:59 PM

Yes, thats right. Thank you :)

For clarification, what's right? To set sqwikiquote's timezone to the same timezone as sqwiki and sqwikinews?

Margott added a comment.EditedApr 23 2019, 4:03 PM

Yes, thats right. Thank you :)

For clarification, what's right? To set sqwikiquote's timezone to the same timezone as sqwiki and sqwikinews?

Yes, its should be Europe/Berlin time just like sqwiki / sqwikinews and UTC just like all the other languages.

Change 505804 merged by jenkins-bot:
[operations/mediawiki-config@master] Set sqwikiquote $wgLocalTimezone

https://gerrit.wikimedia.org/r/505804

Mentioned in SAL (#wikimedia-operations) [2019-04-23T16:07:03Z] <reedy@deploy1001> Synchronized wmf-config/InitialiseSettings.php: set wglocaltimezone for sqwikiquote T221627 (duration: 00m 54s)

Reedy closed this task as Resolved.Apr 23 2019, 4:07 PM
Reedy claimed this task.
Reedy removed a project: Patch-For-Review.