Page MenuHomePhabricator
Create Task
Maniphest T221982

[Tracking] Avoid use of deprecated core classes, class methods, configs, and constants in MF
Closed, ResolvedPublic
Actions

Description

In most cases, and even at the moment, MobileFrontend requires the latest MW version (now master requires 1.35), it would be also good practice to avoid uses of deprecated methods, classes or configs from core in the extension.

I'm particularly interested in cleaning up deprecation usages and wooyaa my root extension for this will now be MobileFrontend. @pmiazga, @Jdlrobson, is it a good idea to always reduce usage of deprecated functions in this extension?

Details

SubjectRepoBranchLines +/-
tests: Avoid usage of deprecated methods in **automated tests**mediawiki/extensions/MobileFrontendmaster+12 -4
api: Avoid use of Languauge::convert(), make use of LanguageConvertermediawiki/extensions/MobileFrontendmaster+5 -5
Avoid usage of deprecated Language::hasVariants() methodmediawiki/extensions/MobileFrontendmaster+5 -3
specials: Avoid usage of deprecated Language::getVariants()mediawiki/extensions/MobileFrontendmaster+4 -4
MobileContext: Avoid usage of deprecated User::getOptions() methodmediawiki/extensions/MobileFrontendmaster+2 -1
specials: Avoid usage of deprecated User::getGroups() methodmediawiki/extensions/MobileFrontendmaster+13 -1
specials: Avoid deprecated calls to User::getOption(), use servicemediawiki/extensions/MobileFrontendmaster+25 -5
Avoid deprecated calls to User::setOption() method, use servicemediawiki/extensions/MobileFrontendmaster+41 -10
Replace deprecated calls to User::getOption() method, use servicemediawiki/extensions/MobileFrontendmaster+15 -8
Replace deprecated calls to User::getOption() method, use servicemediawiki/extensions/MobileFrontendmaster+29 -8
💩 diff: Avoid usage of deprecated `Revision::newFromId()` methodmediawiki/extensions/MobileFrontendmaster+6 -2
💩 specials: Avoid deprecated calls to `->isAllowed()` methodmediawiki/extensions/MobileFrontendmaster+2 -2
💩 api: Avoid use of deprecated MWHttpRequest::factory()mediawiki/extensions/MobileFrontendmaster+4 -1
💩 specials: Follow up on change I24cbcd6ca1d3e85cdc5db70mediawiki/extensions/MobileFrontendmaster+36 -25
Avoid use of deprecated Revision::* constants in MobileFrontendmediawiki/extensions/MobileFrontendmaster+29 -22
Avoid usage of deprecated methods ::getStore() and ::setTOCEnabled()mediawiki/extensions/MobileFrontendmaster+3 -7
Show related patches Customize query in gerrit

Related Objects

Event Timeline

xSavitar created this task.Apr 26 2019, 6:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2019, 6:10 PM
xSavitar renamed this task from Avoid usage of deprecated methods, classes, configs etc in MobileFrontend extension to Avoid usage of deprecated core methods, classes, configs etc in MobileFrontend extension.Apr 26 2019, 6:14 PM
pmiazga added a comment.Apr 26 2019, 6:31 PM

@D3r1ck01 yes, if something is deprecated we should stop using it.

xSavitar renamed this task from Avoid usage of deprecated core methods, classes, configs etc in MobileFrontend extension to (Tracking) Avoid usage of deprecated core methods, classes, configs in MF.EditedApr 26 2019, 6:37 PM

@D3r1ck01 yes, if something is deprecated we should stop using it.

Right! In that case, any deprecation you find in this code base, please you can create a subtask and I'll be more than happy to handle it :)

gerritbot added a comment.Apr 28 2019, 12:49 PM

Change 506899 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] Avoid usage of deprecated methods ::getStore() and ::setTOCEnabled()

https://gerrit.wikimedia.org/r/506899

gerritbot added a project: Patch-For-Review.Apr 28 2019, 12:49 PM
gerritbot added a comment.Apr 29 2019, 1:55 PM

Change 506899 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Avoid usage of deprecated methods ::getStore() and ::setTOCEnabled()

https://gerrit.wikimedia.org/r/506899

xSavitar removed a project: Patch-For-Review.Apr 29 2019, 1:56 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 29 2019, 2:00 PM
pmiazga added a project: Web-Team-Backlog (Tracking).Apr 29 2019, 8:03 PM
xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.Jul 22 2019, 10:19 AM
xSavitar renamed this task from (Tracking) Avoid usage of deprecated core methods, classes, configs in MF to (Tracking) Avoid usage of deprecated core methods, classes, configs, and constants in MF.EditedJul 23 2019, 11:56 AM

I'm cleaning up all constants in the deprecated Revision class, submitting a patch soon.

gerritbot added a comment.Jul 23 2019, 11:57 AM

Change 525067 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] Avoid use of deprecated Revision::* constants in MobileFrontend

https://gerrit.wikimedia.org/r/525067

gerritbot added a project: Patch-For-Review.Jul 23 2019, 11:57 AM
xSavitar renamed this task from (Tracking) Avoid usage of deprecated core methods, classes, configs, and constants in MF to [Tracking] Avoid use of deprecated core classes, class methods, configs, and constants in MF.Jul 23 2019, 11:59 AM
xSavitar moved this task from Doing [WIP] to Under Review on the User-xSavitar board.
gerritbot added a comment.Jul 30 2019, 1:09 AM

Change 525067 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Avoid use of deprecated Revision::* constants in MobileFrontend

https://gerrit.wikimedia.org/r/525067

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2019, 1:10 AM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.16; 2019-07-30); removed MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Jul 30 2019, 2:00 AM
xSavitar updated the task description. (Show Details)Aug 3 2019, 10:38 AM
gerritbot added a comment.Aug 3 2019, 10:41 AM

Change 527838 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] 💩 diff: Avoid usage of deprecated Revision::newFromId() method

https://gerrit.wikimedia.org/r/527838

gerritbot added a project: Patch-For-Review.Aug 3 2019, 10:41 AM
gerritbot added a comment.Aug 3 2019, 11:44 AM

Change 527839 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] 💩 specials: Follow up on change I24cbcd6ca1d3e85cdc5db70

https://gerrit.wikimedia.org/r/527839

gerritbot added a comment.Aug 4 2019, 11:42 AM

Change 527839 abandoned by D3r1ck01:
💩 specials: Follow up on change I24cbcd6ca1d3e85cdc5db70

Reason:
will resurrect this if need be.

https://gerrit.wikimedia.org/r/527839

xSavitar updated the task description. (Show Details)Aug 20 2019, 2:37 AM
gerritbot added a comment.Aug 20 2019, 2:39 AM

Change 531015 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] api: Avoid use of deprecated MWHttpRequest::factory() method

https://gerrit.wikimedia.org/r/531015

xSavitar claimed this task.Aug 21 2019, 12:09 PM
gerritbot added a comment.Aug 23 2019, 12:05 AM

Change 531015 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] 💩 api: Avoid use of deprecated MWHttpRequest::factory()

https://gerrit.wikimedia.org/r/531015

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.20; 2019-08-27); removed MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Aug 23 2019, 1:00 AM
xSavitar removed a project: Patch-For-Review.Feb 4 2020, 3:05 PM
xSavitar updated the task description. (Show Details)
xSavitar updated the task description. (Show Details)
gerritbot added a comment.Feb 4 2020, 3:07 PM

Change 570065 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] specials: Avoid deprecated calls to ->isAllowed() method

https://gerrit.wikimedia.org/r/570065

gerritbot added a project: Patch-For-Review.Feb 4 2020, 3:07 PM
gerritbot added a comment.Feb 7 2020, 3:41 AM

Change 570065 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] 💩 specials: Avoid deprecated calls to ->isAllowed() method

https://gerrit.wikimedia.org/r/570065

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 7 2020, 4:00 AM
xSavitar removed a project: Patch-For-Review.Feb 7 2020, 10:11 AM
xSavitar moved this task from Under Review to Doing [WIP] on the User-xSavitar board.
gerritbot added a comment.Feb 11 2020, 1:40 PM

Change 527838 abandoned by D3r1ck01:
💩 diff: Avoid usage of deprecated Revision::newFromId() method

Reason:
will revisit as part of the deprecation cleanup work I'm doing for MF

https://gerrit.wikimedia.org/r/527838

gerritbot added a comment.Jul 1 2020, 3:35 PM

Change 608876 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] Replace deprecated calls to User::getOption() method, use service

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/ /608876

gerritbot added a project: Patch-For-Review.Jul 1 2020, 3:35 PM
gerritbot added a comment.Jul 1 2020, 4:18 PM

Change 608908 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] Replace deprecated calls to User::getOption() method, use service

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/ /608908

gerritbot added a comment.Jul 1 2020, 4:29 PM

Change 608876 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace deprecated calls to User::getOption() method, use service

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/ /608876

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Jul 1 2020, 5:00 PM
gerritbot added a comment.Jul 1 2020, 10:36 PM

Change 608908 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace deprecated calls to User::getOption() method, use service

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/ /608908

gerritbot added a comment.Jul 2 2020, 8:33 AM

Change 609107 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] Avoid deprecated calls to User::setOption() method, use service

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/ /609107

gerritbot added a comment.Jul 2 2020, 8:51 AM

Change 609108 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] specials: Avoid deprecated calls to User::getOption(), use service

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/ /609108

gerritbot added a comment.Jul 2 2020, 9:35 PM

Change 609107 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Avoid deprecated calls to User::setOption() method, use service

https://gerrit.wikimedia.org/r/609107

gerritbot added a comment.Jul 6 2020, 7:14 PM

Change 609108 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] specials: Avoid deprecated calls to User::getOption(), use service

https://gerrit.wikimedia.org/r/609108

xSavitar removed a project: Patch-For-Review.Jul 6 2020, 9:49 PM
gerritbot added a comment.Jul 7 2020, 12:09 AM

Change 609867 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] specials: Avoid usage of deprecated ->getGroups() method

https://gerrit.wikimedia.org/r/609867

gerritbot added a project: Patch-For-Review.Jul 7 2020, 12:09 AM
gerritbot added a comment.Jul 7 2020, 12:21 AM

Change 609872 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] MobileContext: Avoid usage of deprecated User::getOptons() method

https://gerrit.wikimedia.org/r/609872

gerritbot added a comment.Jul 7 2020, 10:07 PM

Change 609867 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] specials: Avoid usage of deprecated User::getGroups() method

https://gerrit.wikimedia.org/r/609867

gerritbot added a comment.Jul 7 2020, 10:27 PM

Change 609872 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] MobileContext: Avoid usage of deprecated User::getOptions() method

https://gerrit.wikimedia.org/r/609872

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.41; 2020-07-14); removed MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 7 2020, 11:00 PM
xSavitar removed a project: Patch-For-Review.Jul 13 2020, 10:09 PM
gerritbot added a comment.Jul 13 2020, 10:09 PM

Change 612426 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] specials: Avoid usage of deprecated Language::getVariants()

https://gerrit.wikimedia.org/r/612426

gerritbot added a project: Patch-For-Review.Jul 13 2020, 10:09 PM
gerritbot added a comment.Jul 15 2020, 9:26 PM

Change 612426 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] specials: Avoid usage of deprecated Language::getVariants()

https://gerrit.wikimedia.org/r/612426

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 15 2020, 10:00 PM
gerritbot added a comment.Jul 16 2020, 11:52 AM

Change 613135 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] Avoid usage of deprecated Language::hasVariants() method

https://gerrit.wikimedia.org/r/613135

gerritbot added a comment.Jul 17 2020, 7:26 PM

Change 613135 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Avoid usage of deprecated Language::hasVariants() method

https://gerrit.wikimedia.org/r/613135

gerritbot added a comment.Jul 20 2020, 8:48 PM

Change 614860 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] api: Avoid use of Languauge::convert(), make use of LanguageConverter

https://gerrit.wikimedia.org/r/614860

gerritbot added a comment.Jul 21 2020, 10:56 PM

Change 614860 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] api: Avoid use of Languauge::convert(), make use of LanguageConverter

https://gerrit.wikimedia.org/r/614860

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.2; 2020-07-28); removed MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 21 2020, 11:00 PM
Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Jul 24 2020, 2:53 AM
Jdlrobson edited projects, added MobileFrontend (Tracking); removed MobileFrontend.Jul 24 2020, 3:15 PM
gerritbot added a comment.Jul 24 2020, 5:05 PM

Change 616126 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] tests: Avoid usage of deprecated methods in automated tests

https://gerrit.wikimedia.org/r/616126

gerritbot added a comment.Jul 28 2020, 1:44 AM

Change 616126 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] tests: Avoid usage of deprecated methods in automated tests

https://gerrit.wikimedia.org/r/616126

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.3; 2020-08-04); removed MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 28 2020, 2:00 AM
xSavitar closed this task as Resolved.Aug 8 2020, 12:24 PM

All PHP deprecations have been cleaned up apart from:

@Jdlrobson, I'll resolve this task for now and create a new task to track the last remaining things to cleanup! Thanks for all the reviews :)

xSavitar mentioned this in T259970: Wrap-up removal of PHP deprecations from MobileFrontend.Aug 8 2020, 12:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits