Page MenuHomePhabricator
Create Task
Maniphest T222013

Special:Export missing "add" category button when JavaScript is enabled
Closed, ResolvedPublic
Actions

Description

Open https://en.wikipedia.org/wiki/Special:Export in any browser with JavaScript enabled. Note that the "Add" button is missing, so you can't add pages from a category. With JavaScript disabled, it works.

Details

SubjectRepoBranchLines +/-
HTMLFormFieldWithButton: Don't pass empty string as 'id'mediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

FriedhelmW created this task.Apr 27 2019, 9:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2019, 9:03 AM
FriedhelmW added a project: MediaWiki-User-Interface.Apr 27 2019, 9:51 AM
Aklapper edited projects, added OOUI, Regression; removed MediaWiki-User-Interface.Apr 27 2019, 7:41 PM

Thanks for reporting this. Confirming. When using https://en.wikipedia.org/wiki/Special:Export?debug=true it is shown for a moment and then disappears.

If I block https://en.wikipedia.org/w/resources/lib/ooui/oojs-ui-wikimediaui.js the problem does not happen.

Jdforrester-WMF renamed this task from Special:Export missing button when JavaScript is enabled to Special:Export missing "add" category button when JavaScript is enabled.Apr 29 2019, 5:32 PM
gerritbot added a comment.Apr 30 2019, 12:11 AM

Change 507228 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] HTMLFormFieldWithButton: Don't pass empty string as 'id'

https://gerrit.wikimedia.org/r/507228

gerritbot added a project: Patch-For-Review.Apr 30 2019, 12:11 AM
matmarex subscribed.Apr 30 2019, 12:11 AM

Apparently caused by rMW78431d4fba12: HTMLFormFieldWithButton: Allow passing 'inputtype' and pass through 'buttonid'.

gerritbot added a comment.Apr 30 2019, 1:32 AM

Change 507228 merged by jenkins-bot:
[mediawiki/core@master] HTMLFormFieldWithButton: Don't pass empty string as 'id'

https://gerrit.wikimedia.org/r/507228

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 30 2019, 2:00 AM
Aklapper added a project: MediaWiki-HTMLForm.Apr 30 2019, 9:39 AM
matmarex closed this task as Resolved.Apr 30 2019, 7:11 PM
matmarex claimed this task.

The fix will be deployed to Wikimedia wikis this week, 30 April – 2 May, per the usual schedule.

matmarex removed a project: OOUI.Apr 30 2019, 7:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL