"Link to this message" in Special:Translate can produce a link with wrong language code
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikerabbit
	May 6 2019, 9:05 AM

Description

Steps to reproduce:

Go to Special:Translate
Choose a message group
Change a language using the language selector (X)
Open a message and click the "Link to this message" tool in the dropdown on the message key

Observed:
Language is not the chosen language X

Expected:
I am seeing exactly the same message I was looking before, in the correct language.

Details

	Subject	Repo	Branch	Lines +/-
	Fix incorrect link to the message on translate editor	mediawiki/extensions/Translate	master	+8 -2

Customize query in gerrit

Event Timeline

Nikerabbit created this task.May 6 2019, 9:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2019, 9:05 AM

Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.May 6 2019, 9:05 AM

Nikerabbit added a subscriber: abi_.

abi_ added a project: User-abi_.May 6 2019, 4:46 PM

abi_ claimed this task.May 12 2019, 5:25 PM

abi_ triaged this task as Medium priority.

abi_ moved this task from Backlog to In Progress on the User-abi_ board.May 13 2019, 3:24 AM

Change 509842 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Fix incorrect link to the message on translate editor

https://gerrit.wikimedia.org/r/509842

gerritbot added a project: Patch-For-Review.May 13 2019, 1:31 PM

Fixes the incorrect link on Link to this message on the translate editor. Note that linking to a specific messages displays only that message on the message table.

Added code in the message table module to update the targetlangcode data attribute of the message table whenever the target language is updated using the ULS.

Test cases

TC #1 - Link to message should get the correct link

Translate a page to French
Copy the "Link to this message" link
Open the link in a new tab
Then change the target language to Spanish
Copy the "Link to this message" link
Open the link in a new tab

Expected behavior -
On step 3) you should see the French version of the message, and you should see the Spanish version of the message on step 6).

Change 509842 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix incorrect link to the message on translate editor

https://gerrit.wikimedia.org/r/509842

Nikerabbit removed a project: Patch-For-Review.May 20 2019, 1:42 PM

Nikerabbit moved this task from Under Review to QA on the User-abi_ board.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 20 2019, 2:00 PM

Tested this on mediawiki.org, and I see that the language is now part of the query string for Link to message

	F29201796: image.png
	May 22 2019, 10:03 AM

"Link to this message" in Special:Translate can produce a link with wrong language codeClosed, ResolvedPublicActions