Page MenuHomePhabricator

OggHandler fails with fatal error if no PEAR installation in include_path
Closed, ResolvedPublic

Description

OggHandler includes a copy of the PEAR File_Ogg module to read metadata out of ogg files; however it does not include a copy of the base PEAR.php or PEAR/Extension.php which this module requires.

On systems with no default PEAR installation (for instance, Mac OS X 10.5 with Apple's default PHP install), this leads to a PHP fatal error as soon as the system touches an Ogg file and loads up the Ogg module:

Warning: require_once(PEAR.php) [function.require-once]: failed to open stream: No such file or directory in /Library/WebServer/Documents/trunk/extensions/OggHandler/PEAR/File_Ogg/File/Ogg.php on line 114

Fatal error: require_once() [function.require]: Failed opening required 'PEAR.php' (include_path='/Library/WebServer/Documents/trunk/extensions/OggHandler/PEAR/File_Ogg:/Library/WebServer/Documents/trunk:/Library/WebServer/Documents/trunk/includes:/Library/WebServer/Documents/trunk/languages:.:/opt/pear/PEAR') in /Library/WebServer/Documents/trunk/extensions/OggHandler/PEAR/File_Ogg/File/Ogg.php on line 114

Either we should ship a copy with, or we should make the requirements clear.


Version: unspecified
Severity: enhancement

Details

Reference
bz20302