Page MenuHomePhabricator

Cannot change tool LDAP name in Striker
Closed, DeclinedPublic

Description

When I create a tool, the first field is "Unique tool name". This seems to be what becomes the tool ID (LDAP name), as seen in https://toolsadmin.wikimedia.org/tools/id/<TOOL_ID>

I seem to be able to change that "Unique tool name" when editing the toolinfo afterwards, but the tool ID remains the same, both in the URL and for usage in the terminal, e.g. with the become command. So I'm not really sure what's the point of changing that field is (and whether it's worth the potential confusion).

I'd prefer to either being able to change the tool unique name in a way that also changes its ID, or not be able to change the unique name at all (or at least have a separate "LDAP name" field in the tool creation form that has a warning saying it won't be able to be edited in the future).

Event Timeline

bd808 closed this task as Declined.May 19 2019, 8:22 AM

"Unique tool name" is a toolinfo.json attribute, so it it mutable. The tool id is actually the name of an LDAP user and group. Renaming these is in theory possible, but honestly is more work than seems worthwhile to implement. If you want a new tool name, just create a new tool account. :)

waldyrious updated the task description. (Show Details)May 19 2019, 5:18 PM

@bd808 understood, but what about the last suggestion in the task description?

In T223597, @waldyrious wrote:

"Unique tool name" [...] seems to be what becomes the tool ID (LDAP name)
I'd prefer to [...] at least have a separate "LDAP name" field in the tool creation form that has a warning saying it won't be able to be edited in the future.

It could be a read-only field, or maybe simply a label next to the "Unique tool name" field rather than a separate field. Do any of these sound reasonable to you?