Page MenuHomePhabricator
Create Task
Maniphest T223610

Tool creation and toolinfo create/edit forms are the same causing confusion about field mutability/use
Closed, ResolvedPublic
Actions

Description

  • I had a tool whose "Unique tool name" (and LDAP name) was "asdf";
  • I tried to change its ID by editing the "Unique tool name" in the toolinfo edit form. The unique name did change to the new name, "primerpedia", but the LDAP name remained "asdf" (see T223597).
  • Because of that, I tried to create a new tool that would have the correct LDAP name.
  • In the creation tool, I put "primerpedia" in the "Unique tool name" field. I submitted the form without errors and the new tool was created with the "primerpedia" LDAP name.
  • When editing the toolinfo for the new tool, the "Unique tool name" field appeared with "toolforge." prepended.

I would have preferred the tool creation form to warn me that this was going to change and offer me a choice, rather than silently resolve the collision.

Details

SubjectRepoBranchLines +/-
2020-09-02 releaselabs/striker/deploymaster+84 -51
Differentiate tool and toolinfo formslabs/strikermaster+29 -35
Customize query in gerrit

Related Objects

Event Timeline

waldyrious created this task.May 17 2019, 1:56 PM
bd808 added a comment.May 19 2019, 9:59 AM

This is basically a case of poor user interface design making things confusing for you. The toolinfo records are separate and distinct from the actual tool accounts. Any tool account can have 0-N toolinfo records associated with it. These records are purely for the purpose of advertising some aspect of the tool account on Hay's Directory and the 'admin' tool interfaces. The "unique tool name" is a part of the toolinfo.json standard established by Hay's Directory. In an attempt to help ensure the globally unique constraint of that specification, the toolinfo records created via Striker default to using the "toolforge." prefix.

waldyrious added a comment.May 23 2019, 10:21 PM

Understood, @bd808. I suggest keeping this issue open to track clarification of that UI so this confusion no longer happens for others. In the opening comment I suggested two ways that IMO could make the interface clearer.

bd808 added a comment.May 23 2019, 10:37 PM

I think the root problem here is that I used the same form to control two different actions. When it is used to create a new tool, the form does validate that the tool account name is unique. After a tool has been created, the same form is used to create/edit toolinfo records associated with the tool account. Seeing this through your eyes in this task and the related T223597 this seems like a really poor choice I made. As the developer & product owner I knew what I was expecting, but the UI does not make the related but separate concerns clear to the user.

bd808 renamed this task from Tool creation form silently allows using a unique name that already exists to Tool creation and toolinfo create/edit forms are the same causing confusion about field mutability/use.May 23 2019, 10:38 PM
gerritbot added a comment.Jul 28 2020, 11:19 PM

Change 616924 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/striker@master] Differentiate tool and toolinfo forms

https://gerrit.wikimedia.org/r/616924

gerritbot added a project: Patch-For-Review.Jul 28 2020, 11:19 PM
bd808 claimed this task.Jul 28 2020, 11:20 PM
bd808 moved this task from Backlog to Doing on the Striker board.
Restricted Application added a project: User-bd808. · View Herald TranscriptJul 28 2020, 11:20 PM
gerritbot added a comment.Jul 31 2020, 5:38 PM

Change 616924 merged by jenkins-bot:
[labs/striker@master] Differentiate tool and toolinfo forms

https://gerrit.wikimedia.org/r/616924

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2020, 6:10 PM
bd808 moved this task from To Do to Needs Review/Feedback on the User-bd808 board.Aug 3 2020, 1:10 AM
gerritbot added a comment.Aug 28 2020, 11:34 PM

Change 623075 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/striker/deploy@master] Bump striker and wheels sub modules

https://gerrit.wikimedia.org/r/623075

gerritbot added a project: Patch-For-Review.Aug 28 2020, 11:34 PM
gerritbot added a comment.Sep 2 2020, 7:52 PM

Change 623075 merged by jenkins-bot:
[labs/striker/deploy@master] 2020-09-02 release

https://gerrit.wikimedia.org/r/623075

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2020, 8:10 PM
Stashbot mentioned this in T144111: Allow self-service creation of Maniphest projects for Tools.Sep 2 2020, 9:46 PM
Stashbot mentioned this in T198114: Allow tool maintainers to delete toolinfo via ToolsAdmin.

Mentioned in SAL (#wikimedia-operations) [2020-09-02T21:46:25Z] <bd808@deploy1001> Started deploy [striker/deploy@3c2090a]: Deploying r20200902 tag (T198114, T223610, T245804, T144111, T261810)

Stashbot mentioned this in T245804: Reassign base URLs for toolinfo records' web service links.Sep 2 2020, 9:46 PM
Stashbot mentioned this in T261810: Striker not compatible with mwoauth>=0.3.5.

Mentioned in SAL (#wikimedia-operations) [2020-09-02T21:47:59Z] <bd808@deploy1001> Finished deploy [striker/deploy@3c2090a]: Deploying r20200902 tag (T198114, T223610, T245804, T144111, T261810) (duration: 01m 34s)

bd808 closed this task as Resolved.Sep 2 2020, 10:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits