Page MenuHomePhabricator
Create Task
Maniphest T224470

Remove server side category members API calls and depicts/captions forms
Closed, ResolvedPublic
Actions

Description

As all image list retrieval is now client side, we can remove the following:

  • categorymembers api call and processing of the image list in routes.py
  • Depicts and Caption forms - now retrieved via ajax post with JSON data request, so no longer needed
  • Stop serving Participate page with images in Bootstrap carousel (this will be populated on the client side now)

Details

SubjectRepoBranchLines +/-
Remove server side category members API calls and depicts/captions formslabs/tools/Isamaster+8 -148
Customize query in gerrit

Related Objects
Search...

Event Timeline

NavinoEvans created this task.May 28 2019, 12:15 PM
NavinoEvans added a parent task: T224467: Client side category image retrieval with depth on Participate page.
NavinoEvans moved this task from Pending to Backlog on the ISA board.May 28 2019, 2:54 PM
Eugene233 moved this task from Backlog to Pending on the ISA board.May 30 2019, 10:03 PM
NavinoEvans renamed this task from Remove server side category members population of Carousel to Remove server side category members API calls and depicts/captions forms.Jun 7 2019, 9:36 AM
NavinoEvans updated the task description. (Show Details)
gerritbot added a comment.Jun 10 2019, 8:20 AM

Change 516143 had a related patch set uploaded (by Eugene233; owner: Eugene233):
[labs/tools/Isa@master] Remove server side category members API calls and depicts/captions forms

https://gerrit.wikimedia.org/r/516143

gerritbot added a project: Patch-For-Review.Jun 10 2019, 8:20 AM
Eugene233 mentioned this in rLTISc83ac9713d01: Remove server side category members API calls and depicts/captions forms.Jun 10 2019, 8:27 AM
Eugene233 mentioned this in rLTIS753aa0979b8b: Remove server side category members API calls and depicts/captions forms.Jun 10 2019, 2:26 PM
gerritbot added a comment.Jun 10 2019, 3:02 PM

Change 516143 merged by jenkins-bot:
[labs/tools/Isa@master] Remove server side category members API calls and depicts/captions forms

https://gerrit.wikimedia.org/r/516143

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2019, 3:10 PM
Eugene233 closed this task as Resolved.Jun 11 2019, 6:31 AM

Marking as resolved.

NavinoEvans moved this task from Pending to Complete (deployed) on the ISA board.Mar 12 2020, 5:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits