Page MenuHomePhabricator

Add phan to LiquidThreads extension
Closed, ResolvedPublic

Description

As wmf deployed extension the LiquidThreads extension should run phan on CI to found simple bugs in an earlier state of development.
LiquidThreads extension is not using the common /includes/ or /src/ folder, which makes the config for phan a bit harder.
It also mixed up \Page and \Article at some places which makes it harder to follow the code for phan

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2019, 7:57 PM

Change 528937 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] [LiquidThreads] Add phan dependency

https://gerrit.wikimedia.org/r/528937

Change 528939 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/LiquidThreads@master] build: Add mediawiki/mediawiki-phan-config

https://gerrit.wikimedia.org/r/528939

Change 528937 merged by jenkins-bot:
[integration/config@master] [LiquidThreads] Add phan dependency

https://gerrit.wikimedia.org/r/528937

Change 528939 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] build: Add mediawiki/mediawiki-phan-config

https://gerrit.wikimedia.org/r/528939

Umherirrender closed this task as Resolved.Aug 24 2019, 9:40 PM
Umherirrender claimed this task.
Umherirrender triaged this task as Medium priority.