Page MenuHomePhabricator
Create Task
Maniphest T225223

Change DatabaseTermIdsAcquirer restoration logic to use only master DB when restoring ids
Closed, ResolvedPublic
Actions

Description

Current behavior

DatabaseTermIdsAcquirer::resotreCleanedUpIds() still looks up the ids in replicas first when deciding what to restore. This might have the risk of missing out on cases where replica didn't catch up with deleted records in master, and will falsely make restoration logic bypass restoring those.

Expected behavior
DatabaseTermIdsAcquirer::resotreCleanedUpIds() must only lookup ids in master, and entirely ignore replicas as if they do not exist.

TODO:

Details

SubjectRepoBranchLines +/-
Ignore replica in internal acquirers when restoring cleaned up idsmediawiki/extensions/Wikibasemaster+160 -32
Allow a configuration for bypassing replica altogether in ReplicaMasterAwareRecordIdsAcquirermediawiki/extensions/Wikibasemaster+49 -8
Customize query in gerrit

Event Timeline

• alaa_wmde created this task.Jun 6 2019, 3:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2019, 3:04 PM
• alaa_wmde claimed this task.Jun 6 2019, 3:04 PM
• alaa_wmde updated the task description. (Show Details)
gerritbot added a comment.Jun 6 2019, 3:13 PM

Change 514740 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] Allow a configuration for bypassing replica altogether in ReplicaMasterAwareRecordIdsAcquirer

https://gerrit.wikimedia.org/r/514740

gerritbot added a project: Patch-For-Review.Jun 6 2019, 3:13 PM
• alaa_wmde updated the task description. (Show Details)Jun 6 2019, 3:14 PM
gerritbot added a comment.Jun 6 2019, 3:56 PM

Change 514752 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] Ignore replica in internal acquirers when restoring cleaned up ids

https://gerrit.wikimedia.org/r/514752

• alaa_wmde updated the task description. (Show Details)Jun 6 2019, 3:56 PM
• alaa_wmde moved this task from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
gerritbot added a comment.Jun 11 2019, 3:15 PM

Change 514740 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Allow a configuration for bypassing replica altogether in ReplicaMasterAwareRecordIdsAcquirer

https://gerrit.wikimedia.org/r/514740

gerritbot added a comment.Jun 11 2019, 3:15 PM

Change 514752 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Ignore replica in internal acquirers when restoring cleaned up ids

https://gerrit.wikimedia.org/r/514752

• alaa_wmde closed this task as Resolved.Jun 11 2019, 3:36 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 11 2019, 4:00 PM
Lucas_Werkmeister_WMDE moved this task from In Review to Done on the Wikidata wb_terms Trailblazing board.Jun 12 2019, 10:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits