Page MenuHomePhabricator

Change DatabaseTermIdsAcquirer restoration logic to use only master DB when restoring ids
Closed, ResolvedPublic

Description

Current behavior

DatabaseTermIdsAcquirer::resotreCleanedUpIds() still looks up the ids in replicas first when deciding what to restore. This might have the risk of missing out on cases where replica didn't catch up with deleted records in master, and will falsely make restoration logic bypass restoring those.

Expected behavior
DatabaseTermIdsAcquirer::resotreCleanedUpIds() must only lookup ids in master, and entirely ignore replicas as if they do not exist.

TODO:

Event Timeline

alaa_wmde created this task.Jun 6 2019, 3:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2019, 3:04 PM
alaa_wmde claimed this task.Jun 6 2019, 3:04 PM
alaa_wmde updated the task description. (Show Details)

Change 514740 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] Allow a configuration for bypassing replica altogether in ReplicaMasterAwareRecordIdsAcquirer

https://gerrit.wikimedia.org/r/514740

alaa_wmde updated the task description. (Show Details)Jun 6 2019, 3:14 PM

Change 514752 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] Ignore replica in internal acquirers when restoring cleaned up ids

https://gerrit.wikimedia.org/r/514752

alaa_wmde updated the task description. (Show Details)Jun 6 2019, 3:56 PM
alaa_wmde moved this task from In Progress to In Review on the Wikidata wb_terms Trailblazing board.

Change 514740 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Allow a configuration for bypassing replica altogether in ReplicaMasterAwareRecordIdsAcquirer

https://gerrit.wikimedia.org/r/514740

Change 514752 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Ignore replica in internal acquirers when restoring cleaned up ids

https://gerrit.wikimedia.org/r/514752

alaa_wmde closed this task as Resolved.Jun 11 2019, 3:36 PM