Page MenuHomePhabricator

Insert, Replace buttons shall be triggered when enter key is pressed
Closed, ResolvedPublic

Description

Author: wikibugs

Description:
Reporting against Babaco Release. (Hosted on http://prototype.wikimedia.org)

Steps to Reproduce ::
1)Open dialog boxes ( Inserting Link, Insert table and Search and Replace)
2)Click Enter button

<<Nothing happens >>

Expected Outcome ::
Insert, Replace buttons shall be invoked when Enter key is pressed

Note : Dialogs are closed when Esc is pressed (as expected)

Test Environment (Client) ::
Browser (User-Agent): Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Javascript: Enabled
Cookies Enabled: Enabled
Java Enabled: Enabled
CPU class/type: OS/CPU Windows NT 6.0
Screen Width x Height: 1280 x 800
Screen Color Depth: 32


Version: unspecified
Severity: trivial
OS: Windows Vista
Platform: PC
URL: http://usability.wikimedia.org/wiki/Releases/Babaco/Compatibility_Matrix

Details

Reference
bz20605

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:47 PM
bzimport set Reference to bz20605.

wikibugs wrote:

Insert, Replace buttons shall be invoked when Enter key is pressed. But user should enter a single value for one of the fields.

wikibugs wrote:

Steps to reproduce the new issue:

  1. Open a dialog box (Inserting Link or Insert table or Search and Replace window).
  2. Give a value to one of a fields and click on the window.
  3. Now Click "Enter" button.

<<Nothing happens >>

Expected Outcome ::
Insert, Replace buttons shall be invoked when Enter key is pressed.

(In reply to comment #3)

Steps to reproduce the new issue:

  1. Open a dialog box (Inserting Link or Insert table or Search and Replace

window).

  1. Give a value to one of a fields and click on the window.
  2. Now Click "Enter" button.

<<Nothing happens >>

Expected Outcome ::
Insert, Replace buttons shall be invoked when Enter key is pressed.

Fixed in r56948. In some browsers (for instance in Chrome), fixing this seems to be impossible because there's no way to catch keypresses on things that aren't textboxes (that I know of).

wikibugs wrote:

Tested for all browsers.
Working fine.

wikibugs wrote:

Added keyword babaco to the bug

wikibugs wrote:

Reproducible this bug on the following browser for 'Insert Table' functionality.

<<Cannot create a table when click 'Enter' key>>

Test Environment::
Browser (User-Agent): Opera/9.50 (Macintosh; Intel Mac OS X; U; en)
Time and Date: 10:36:16 AM - Monday, October 05, 2009
Javascript: Enabled
Cookies Enabled: Enabled
Java Enabled: Enabled

Since we blacklisted Opera < 9.6, bugs for Opera 9.5 are no longer valid. Reclosing as FIXED.