Only make data bridge ResourceLoader modules available if data bridge is enabled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Jul 1 2019, 11:52 AM

Description

Originally part of the second Gerrit chain in T226494: Create configuration for matching regex: we probably don’t want to make the work-in-progress data bridge modules available in production. Currently, they’re defined anywhere, and the “enabled or not” setting only determines whether we load them by default or not.

Patch-For-Review:

main change
optional additional chain to move config into a separate module

Details

	Subject	Repo	Branch	Lines +/-
	bridge: conditionally load module	mediawiki/extensions/Wikibase	master	+31 -12

Customize query in gerrit

Related Objects

Mentioned In: T226494: Create configuration for matching regex
Mentioned Here: T226494: Create configuration for matching regex

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 1 2019, 11:52 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2019, 11:52 AM

Lucas_Werkmeister_WMDE claimed this task.Jul 1 2019, 11:52 AM

Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-0 board.

Change 519994 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: conditionally load module

https://gerrit.wikimedia.org/r/519994

gerritbot added a project: Patch-For-Review.Jul 1 2019, 12:19 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 1 2019, 12:21 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-0 board.

Lucas_Werkmeister_WMDE mentioned this in T226494: Create configuration for matching regex.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 1 2019, 12:23 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 2 2019, 2:59 PM

Change 520255 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add client-side warning for missing config

https://gerrit.wikimedia.org/r/520255

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 2 2019, 3:02 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Change 519994 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: conditionally load module

https://gerrit.wikimedia.org/r/519994

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 2 2019, 3:54 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 2 2019, 4:00 PM

• Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-1; removed MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, Wikidata-Bridge-Sprint-0, Wikidata.Jul 3 2019, 9:24 AM

• Pablo-WMDE moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-1 board.Jul 3 2019, 9:24 AM

darthmon_wmde added projects: Wikidata, Wikidata-Bridge-Sprint-0.Jul 3 2019, 9:26 AM

• Pablo-WMDE updated the task description. (Show Details)Jul 3 2019, 5:01 PM

• Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-1 board.

• Pablo-WMDE closed this task as Resolved.Jul 17 2019, 8:52 AM

Only make data bridge ResourceLoader modules available if data bridge is enabledClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Only make data bridge ResourceLoader modules available if data bridge is enabled
Closed, ResolvedPublic
Actions