Check usages/ purpose of GenericServices::getCompactBaseDataModelSerializerFactory
Open, LowPublic0 Estimated Story Points
Actions

Assigned To

None

Authored By

	hoo
	Jul 4 2019, 12:55 PM

Description

In T227207: Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes we discovered that GenericServices::getCompactBaseDataModelSerializerFactory is used to create entity JSON output for the dumps and Special:EntityData. The function is documented as Factory creating serializers that generate the most compact serialization., but that doesn't seem to be the way it is used currently (we expect hashes in the output for example).

We should look how/ where this function is used and whether it is appropriate.
Fix all usages
The function should be changed to using SerializerFactory::OPTION_SERIALIZE_SNAKS_WITHOUT_HASH again (essentially revert 881780ae6b1f5cacb224efa9fa065599e51bb028)

Related Objects

Mentioned In: T227207: Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes
Mentioned Here: T227207: Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes
rEWBA881780ae6b1f: Fix missing qualifier hashes in JSON output

Event Timeline

hoo created this task.Jul 4 2019, 12:55 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 4 2019, 12:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

GenericServices::getCompactBaseDataModelSerializerFactory, which is set to omit hashes for references and mainsnaks, is used for everything, but references are correctly included. So either they're injected later on (but I don't see that happening) or the requested omission is not working correctly, it seems.

hoo added a project: MediaWiki-extensions-WikibaseRepository.Jul 4 2019, 1:27 PM

hoo mentioned this in T227207: Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes.Jul 4 2019, 1:33 PM

Addshore moved this task from Incoming to Needs Tech Work on the Wikidata-Campsite board.Jan 27 2020, 4:06 PM

Addshore subscribed.Feb 3 2020, 1:58 PM

Addshore added a project: [DEPRECATED] wdwb-tech.Apr 14 2021, 9:38 AM

Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.Apr 14 2021, 4:03 PM

Addshore removed a project: Wikidata-Campsite.Apr 22 2021, 3:59 PM

Addshore triaged this task as Low priority.Aug 24 2021, 10:40 AM

Addshore moved this task from To Prioritize to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.

Addshore unsubscribed.Jun 27 2023, 12:43 PM