Page MenuHomePhabricator

Magnifier search icon in main search bar should not be mirrored in RTL languages
Closed, ResolvedPublic

Description

While working on releasing the Growth Experiments to Arabic wiki, the Growth team noticed how the magnifier search icon of the main desktop search bar in the chrome area of the screen is mirrored in RTL languages T227154.

According to OOUI and to this comment T227154#5304657 by @Volker_E that should not happen.
The icon should correctly be rendered with the handle pointing bottom right in RTL.

Details

Related Gerrit Patches:

Event Timeline

Cntlsn created this task.Jul 18 2019, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2019, 3:21 PM
Volker_E edited projects, added Vector, I18n; removed OOUI.Jul 18 2019, 3:22 PM

The alignment seems right(!) to me, as the icon is a search button trigger in Vector, while in OOUI it's an indication icon.

Also see T220598 and T227991 on related issues...

Cntlsn updated the task description. (Show Details)Jul 18 2019, 4:30 PM

Change 524291 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] Remove falesly introduced RTL version of 'search' icon

https://gerrit.wikimedia.org/r/524291

Change 524291 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Remove falesly introduced RTL version of 'search' icon

https://gerrit.wikimedia.org/r/524291

Volker_E closed this task as Resolved.Jul 18 2019, 9:15 PM
Volker_E claimed this task.
Volker_E added a project: UI-Standardization.