Maniphest T229123

ApiSandbox: upload widget no longer functions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Anomie
	Jul 26 2019, 3:03 PM

Tags

Referenced Files

None

Subscribers

Description

When attempting to make the request with for action=upload with the 'file' field enabled, the JavaScript console (at least in Firefox 68) logs "TypeError: this.setIcon is not a function" and the request is not sent.

This was probably broken by rGOJU4d76a9d9fd4f: Rewrite SelectFileInputWidget as an ActionFieldLayout, which removed OO.ui.mixin.IconElement from SelectFileWidget / SelectFileInputWidget.

Details

	Subject	Repo	Branch	Lines +/-
	ApiSandbox: Fix upload widget	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: rGOJU4d76a9d9fd4f: Rewrite SelectFileInputWidget as an ActionFieldLayout

Event Timeline

Anomie created this task.Jul 26 2019, 3:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2019, 3:03 PM

Anomie claimed this task.Jul 26 2019, 3:03 PM

Change 525826 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiSandbox: Fix upload widget

https://gerrit.wikimedia.org/r/525826

gerritbot added a project: Patch-For-Review.Jul 26 2019, 3:05 PM

Anomie moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Jul 26 2019, 3:06 PM

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.

Change 525826 merged by jenkins-bot:
[mediawiki/core@master] ApiSandbox: Fix upload widget

https://gerrit.wikimedia.org/r/525826

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2019, 4:10 PM

Anomie closed this task as Resolved.Jul 26 2019, 4:18 PM

Anomie moved this task from Waiting for Review to EM Sign Off on the Platform Team Workboards (Clinic Duty Team) board.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 26 2019, 5:00 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM