Page MenuHomePhabricator

ApiSandbox: upload widget no longer functions
Closed, ResolvedPublic

Description

When attempting to make the request with for action=upload with the 'file' field enabled, the JavaScript console (at least in Firefox 68) logs "TypeError: this.setIcon is not a function" and the request is not sent.

This was probably broken by rGOJU4d76a9d9fd4f: Rewrite SelectFileInputWidget as an ActionFieldLayout, which removed OO.ui.mixin.IconElement from SelectFileWidget / SelectFileInputWidget.

Event Timeline

Anomie created this task.Jul 26 2019, 3:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2019, 3:03 PM
Anomie claimed this task.Jul 26 2019, 3:03 PM

Change 525826 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiSandbox: Fix upload widget

https://gerrit.wikimedia.org/r/525826

Change 525826 merged by jenkins-bot:
[mediawiki/core@master] ApiSandbox: Fix upload widget

https://gerrit.wikimedia.org/r/525826