Page MenuHomePhabricator
Create Task
Maniphest T231041

Clean up `groupOverrides` to remove unneeded entries
Closed, ResolvedPublic
Actions

Description

There are a number of entries in groupOverrides that duplicate existing defaults or entries. These entries are extraneous and should be removed, both for code readability and because they unnecessarily bloat the size of InitialiseSettings.php.

Details

SubjectRepoBranchLines +/-
General cleanup of `groupOverrides`.operations/mediawiki-configmaster+134 -289
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Aug 22 2019, 7:41 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 22 2019, 7:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Aug 22 2019, 7:41 PM

Change 531741 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[operations/mediawiki-config@master] Clean up groupOverrides to remove unneeded entries

https://gerrit.wikimedia.org/r/531741

gerritbot added a project: Patch-For-Review.Aug 22 2019, 7:41 PM
DannyS712 moved this task from Backlog to To deploy on the Wikimedia-Site-requests board.Aug 22 2019, 8:57 PM
DannyS712 added a project: User-Urbanecm.
DannyS712 moved this task from Backlog to To deploy on the User-Urbanecm board.
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
Urbanecm moved this task from To deploy to Blocked on others on the User-Urbanecm board.Aug 22 2019, 9:22 PM
gerritbot added a comment.Aug 22 2019, 11:19 PM

Change 531741 merged by jenkins-bot:
[operations/mediawiki-config@master] General cleanup of groupOverrides.

https://gerrit.wikimedia.org/r/531741

Stashbot added a comment.Aug 22 2019, 11:24 PM

Mentioned in SAL (#wikimedia-operations) [2019-08-22T23:24:13Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: 66b719d: General cleanup of groupOverrides (T231041) (duration: 00m 47s)

Urbanecm closed this task as Resolved.Aug 22 2019, 11:24 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 23 2019, 12:10 AM
DannyS712 mentioned this in T231178: General cleanup of initialize settings.Aug 25 2019, 10:10 PM
DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.Sep 24 2019, 5:36 AM
DannyS712 moved this task from Merged to Config (deployed) on the User-DannyS712 board.Dec 23 2019, 1:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL