Page MenuHomePhabricator

Browser tests failing now AMC Outreach drawer is enabled
Closed, ResolvedPublic


Minerva has been failing for 3 builds since we turned the AMC outreach drawer on.
It blocks the user from doing anything.

This test failure while annoying makes a point that the nature of the interstitial blocks interaction across the site.

Developer notes

At minimum we need to find a way to disable this for the Selenium user.
We could look into disabling this for users in certain groups. e.g. bots

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2019, 11:33 PM
nray added a subscriber: nray.Aug 23 2019, 5:28 PM

Does "Selenium user" run for all logged in tests? Or are there multiple users running the integration tests?

Selenium user is the only one we need to care about. These tests will fail for as long as the Outreach drawer is enabled.

Change 531959 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Prevent Amc Outreach from showing when user is a bot

Change 531959 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Prevent Amc Outreach from showing when user is a bot

Jdlrobson triaged this task as High priority.
Jdlrobson closed this task as Resolved.Aug 23 2019, 11:59 PM

Green again!