Page MenuHomePhabricator
Create Task
Maniphest T231057

Browser tests failing now AMC Outreach drawer is enabled
Closed, ResolvedPublic
Actions

Description

Minerva has been failing for 3 builds since we turned the AMC outreach drawer on.
It blocks the user from doing anything.

This test failure while annoying makes a point that the nature of the interstitial blocks interaction across the site.

Developer notes

At minimum we need to find a way to disable this for the Selenium user.
We could look into disabling this for users in certain groups. e.g. bots
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:ListUsers&limit=1&username=Selenium+user

Details

SubjectRepoBranchLines +/-
Prevent Amc Outreach from showing when user is a botmediawiki/extensions/MobileFrontendmaster+3 -1
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Aug 22 2019, 11:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2019, 11:33 PM
• nray subscribed.Aug 23 2019, 5:28 PM

Does "Selenium user" run for all logged in tests? Or are there multiple users running the integration tests?

Jdlrobson added a comment.Aug 23 2019, 5:39 PM

Selenium user is the only one we need to care about. These tests will fail for as long as the Outreach drawer is enabled.

gerritbot added a comment.Aug 23 2019, 5:54 PM

Change 531959 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Prevent Amc Outreach from showing when user is a bot

https://gerrit.wikimedia.org/r/531959

gerritbot added a project: Patch-For-Review.Aug 23 2019, 5:54 PM
gerritbot added a comment.Aug 23 2019, 10:13 PM

Change 531959 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Prevent Amc Outreach from showing when user is a bot

https://gerrit.wikimedia.org/r/531959

Jdlrobson claimed this task.Aug 23 2019, 10:14 PM
Jdlrobson triaged this task as High priority.
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 23 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 23 2019, 11:10 PM
Jdlrobson closed this task as Resolved.Aug 23 2019, 11:59 PM

Green again!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits