Page MenuHomePhabricator

Collapsing tabs not listing all in the drop down except for read and edit
Closed, InvalidPublic

Description

Author: wikibugs

Description:
Screen print of the error

Reporting against Babaco Release : r57727

Steps to Reproduce ::

  1. Login to http://prototype.wikimedia.org/en.wikipedia.org/Main_Page
  2. Select a random page
  3. Make the window smaller

<<Only one tab is shown in the drop down.>>

Expected Outcome::
All the tabs other than read and edit should shown in the drop down

Test Environment::

Browser (User-Agent): Opera/9.63 (Windows NT 6.0; U; en) Presto/2.1.1

Browser (User-Agent): Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0 (.NET CLR 3.5.30729)

Browser (User-Agent): Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3


Version: unspecified
Severity: critical

Attached:

Details

Reference
bz21203

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:49 PM
bzimport set Reference to bz21203.

The source of this seems to be that CollapsibleTabs only collapses one tab at a time, which breaks for sudden big resizings like maximize<->normal size.

amiller1 wrote:

The real reason nothing else is collapsing is because we're only instructing it to collapse the view history item.

Collapsible items are identified by a css selector, and by default it's set to 'li.collapsible'. Vector is only applying that to view history currently. I will inquire if this is not the desired functionality, will apply the change if it's needed.

There WAS a bug in the javascript which I just corrected in r57953 which was preventing multiple tabs from collapsing on one resize event, but that will not alter the functionality here since we only have one tab marked as collapsible.

(In reply to comment #2)

The real reason nothing else is collapsing is because we're only instructing it
to collapse the view history item.

Collapsible items are identified by a css selector, and by default it's set to
'li.collapsible'. Vector is only applying that to view history currently. I
will inquire if this is not the desired functionality, will apply the change if
it's needed.

There WAS a bug in the javascript which I just corrected in r57953 which was
preventing multiple tabs from collapsing on one resize event, but that will not
alter the functionality here since we only have one tab marked as collapsible.

No we don't, we also have the Add topic tab on talk pages, which is also collapsible, so the JS bug you fixed actually did have a real effect.

wikibugs wrote:

The issue still exists

wikibugs wrote:

Screen print of the error

Attached:

amiller1 wrote:

I can't replicate this. The View History tab moves into the drop down just fine for me. The Watch/Unwatch icon is not intended to move, so I'm not sure what the problem is.

(In reply to comment #6)

I can't replicate this. The View History tab moves into the drop down just fine
for me. The Watch/Unwatch icon is not intended to move, so I'm not sure what
the problem is.

Could Calcey confirm whether this is issue is still present?

nkomura wrote:

(In reply to comment #5)

Created an attachment (id=6750) [details]
Screen print of the error

Could we have more information about this report? What is the brower and OS when the issue was encountered? What was the resolution?

wikibugs wrote:

Screen prints of the error

Attached:

wikibugs wrote:

Resolution : 720 x 576

Please refer to the attachment id 6777

In the normal resolution there are 04 tabs as Read,View Source,View History and the Star
When the screen come down to a resolution less than 800 x 600 then only View History goes to the drop down.

As we understand the requirement "the window resolutions is scaled down to the point when the tabs starts overlapping. Tabs will be tucked away in the drop down menu except "Read" and "Edit" tabs"
So the View Source also should be listed in the drop down but it isn't. According to the comment #6 the Start also should not be listed also.

That is the error we have pointed.

(In reply to comment #10)

Resolution : 720 x 576

Please refer to the attachment id 6777

In the normal resolution there are 04 tabs as Read,View Source,View History and
the Star
When the screen come down to a resolution less than 800 x 600 then only View
History goes to the drop down.

As we understand the requirement "the window resolutions is scaled down to the
point when the tabs starts overlapping. Tabs will be tucked away in the drop
down menu except "Read" and "Edit" tabs"
So the View Source also should be listed in the drop down but it isn't.
According to the comment #6 the Start also should not be listed also.

This is partly a misunderstanding, and partly a misstatement of the feature. The View Source tab is really the Edit tab with another caption (it points to the same URL), therefore it's not collapsed. The watch star is also not collapsed by design, since it's so small.

wikibugs wrote:

Close as of Comment #11