Page MenuHomePhabricator

The Wikibase web interface shows non-functional sitelink groups
Closed, ResolvedPublic

Description

Problem: On a fresh Wikibase installation the web interface shows all the possible sitelink groups supported by Wikidata even if they don't work locally (by default they aren't enabled). Only locally enabled and fully functional sitelink groups should appear on the Wikibase web interface. The sitelink groups can be selectively enabled with $wgWBRepoSettings['siteLinkGroups'] (see https://www.mediawiki.org/wiki/Wikibase/Installation#Enable_Sitelinks).

Screenshots/mockups (current state):

Acceptance criteria:

  • Only locally enabled and fully functional sitelink groups appear on the Wikibase web interface.

Open questions:

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterMove siteLinkGroups to default config and empty
mediawiki/extensions/Wikibase : masterRemove siteLink groups from Wikibase registry

Event Timeline

abian created this task.Sep 7 2019, 11:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2019, 11:37 AM

Looks like we tried to fix this at some point but it got lost in the backlog of things.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/474844/

From the looks of things, there was not a phab ticket for that original patch.

Change 474844 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Addshore):
[mediawiki/extensions/Wikibase@master] Move siteLinkGroups to default config and empty

https://gerrit.wikimedia.org/r/474844

Addshore triaged this task as Low priority.Sep 27 2019, 6:51 PM
Addshore added a project: Wikidata-Campsite.
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
alaa_wmde raised the priority of this task from Low to Medium.Oct 1 2019, 11:31 AM
alaa_wmde added a subscriber: alaa_wmde.

Let's review the associated patch and resolve this. It is desirable to solve from product perspective for 3rd party installations.

alaa_wmde claimed this task.Oct 1 2019, 1:49 PM

Worked a bit on this trying to fix the tests.. but apparently a day was not enough, and what I thought was a solution (basically setting up the sites needed for relevant tests relevant tests which made them pass) caused other tests to fail.

Gonna need a bit more focus than that, so moved back to Ready to Pickup for lack of time currently

Change 547543 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove siteLink groups from Wikibase registry

https://gerrit.wikimedia.org/r/547543

Change 547543 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove siteLink groups from Wikibase registry

https://gerrit.wikimedia.org/r/547543

Change 474844 abandoned by Alaa Sarhan:
Move siteLinkGroups to default config and empty

Reason:
already resolved in 547543

https://gerrit.wikimedia.org/r/474844