Page MenuHomePhabricator
Create Task
Maniphest T232761

Filters shouldn't `block autopromote` for anonymous users
Closed, ResolvedPublic
Actions

Description

See, eg, https://meta.wikimedia.org/w/index.php?title=Special:AbuseLog&wpSearchUser=86.179.176.115

Steps to reproduce (theoretical):
Editing anonymously, trigger a filter with the consequence of block autopromote

Expected result:
Since anonymous users cannot be autopromoted, no log entry of block autopromote is registered

Actual result:
Log entry is still registered

Details

SubjectRepoBranchLines +/-
Avoid processing blockautopromote and degroup for anonsmediawiki/extensions/AbuseFiltermaster+98 -69
Customize query in gerrit

Event Timeline

DannyS712 created this task.Sep 12 2019, 5:00 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 12 2019, 5:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Abuse Filter on the User-DannyS712 board.Sep 12 2019, 5:00 PM
Daimona subscribed.Sep 12 2019, 5:01 PM

Two quick notes:
1-It's not even trying to block autopromotion, it's just the log entry being wrong
2-The same issue affects 'degroup'

Daimona added a comment.Sep 12 2019, 5:06 PM

3-This should be handled by executeFilterActions, not takeConsequenceAction

gerritbot added a comment.Sep 13 2019, 1:13 PM

Change 536587 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Avoid processing blockautopromote and degroup for anons

https://gerrit.wikimedia.org/r/536587

gerritbot added a project: Patch-For-Review.Sep 13 2019, 1:13 PM
Daimona claimed this task.Sep 13 2019, 1:14 PM
gerritbot added a comment.Dec 8 2020, 10:37 PM

Change 536587 abandoned by Daimona Eaytoy:
[mediawiki/extensions/AbuseFilter@master] Avoid processing blockautopromote and degroup for anons

Reason:

https://gerrit.wikimedia.org/r/536587

Daimona closed this task as Resolved.Dec 8 2020, 10:37 PM
Daimona removed a project: Patch-For-Review.

Resolved with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/633380

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL