Page MenuHomePhabricator
Create Task
Maniphest T233002

Source wiki edit comment has bad URL
Closed, ResolvedPublic
Actions

Description

In T228851#5495407 we saw,

This file is now on Wikipedia as \/\/test.wikipedia.org\/wiki\/File:038pro01.jpg

Similar to T228846, probably the same fix, passing the PROTO_CANONICAL flag to Title#getFullUrl.

Details

SubjectRepoBranchLines +/-
Source wiki edit comment has bad URLmediawiki/extensions/FileImportermaster+8 -4
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Sep 16 2019, 12:30 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptSep 16 2019, 12:30 PM
awight moved this task from Backlog to Tickets in sprint on the Move-Files-To-Commons board.Sep 18 2019, 7:43 AM
awight added a project: WMDE-QWERTY-Sprint-2019-09-10.
Andrew-WMDE claimed this task.Sep 18 2019, 7:46 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-09-10 board.
gerritbot added a comment.Sep 18 2019, 8:29 AM

Change 537598 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@master] Source wiki edit comment has bad URL

https://gerrit.wikimedia.org/r/537598

gerritbot added a project: Patch-For-Review.Sep 18 2019, 8:30 AM
Andrew-WMDE moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2019-09-10 board.Sep 18 2019, 9:04 AM
gerritbot added a comment.Sep 18 2019, 9:13 AM

Change 537598 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Source wiki edit comment has bad URL

https://gerrit.wikimedia.org/r/537598

Andrew-WMDE mentioned this in rEFLI8b84716d5f49: Source wiki edit comment has bad URL.Sep 18 2019, 9:14 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 18 2019, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 18 2019, 10:10 AM
awight moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2019-09-10 board.Sep 18 2019, 12:11 PM
Andrew-WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2019-09-10 board.Sep 25 2019, 9:35 AM
awight added a comment.Sep 25 2019, 10:00 AM

@Andrew-WMDE if it's easy, please link to the "receipts" you created when accepting tasks.

Andrew-WMDE added a comment.Sep 25 2019, 11:36 AM

Verified by import from test2 to testwiki, see edit summaries on test2:
https://test2.wikipedia.org/w/index.php?title=File%3A038pro01.jpg&type=revision&diff=409658&oldid=408831

awight closed this task as Resolved.Sep 25 2019, 12:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits