Malformed URL in imported file comment
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	awight
	Jul 24 2019, 10:18 AM

Description

(Import log); 01:36 Taiwania Justo talk contribs imported File:Chinshin High School high front view.jpg from another wiki ‎(Imported with FileImporter from //zh.wikipedia.org/wiki/File:Chinshin_High_School_high_front_view.jpg) Tag: Imported with FileImporter

The source wiki URL is missing a protocol, e.g. "https://".

Details

	Subject	Repo	Branch	Lines +/-
	Tests for FileImporter URL	mediawiki/extensions/FileExporter	master	+149 -61
	Always include protocol in clientUrl	mediawiki/extensions/FileExporter	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: rEFILEEXPORT17f71f47cf72: Tests for FileImporter URL
T233002: Source wiki edit comment has bad URL
T228851: Source wiki editing and deletion always fails
rEFILEEXPORTbf8bd16e66f0: Always include protocol in clientUrl

Event Timeline

awight created this task.Jul 24 2019, 10:18 AM

Restricted Application added a subscriber: Stang. · View Herald TranscriptJul 24 2019, 10:18 AM

awight changed the subtype of this task from "Task" to "Bug Report".Jul 24 2019, 10:18 AM

Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Move-Files-To-Commons board.Jul 25 2019, 9:53 AM

awight set the point value for this task to 1.Aug 21 2019, 1:34 PM

awight claimed this task.Aug 30 2019, 9:20 AM

awight moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.

awight added a project: WMDE-QWERTY-Sprint-2019-08-21 .

Change 533489 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileExporter@master] Always include protocol in clientUrl

https://gerrit.wikimedia.org/r/533489

gerritbot added a project: Patch-For-Review.Aug 30 2019, 9:41 AM

awight moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-08-21 board.Aug 30 2019, 9:42 AM

Change 533489 merged by jenkins-bot:
[mediawiki/extensions/FileExporter@master] Always include protocol in clientUrl

https://gerrit.wikimedia.org/r/533489

awight mentioned this in rEFILEEXPORTbf8bd16e66f0: Always include protocol in clientUrl.Aug 30 2019, 3:25 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 30 2019, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2019, 4:10 PM

awight moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2019-08-21 board.Sep 2 2019, 12:57 PM

Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2019-09-04.Sep 4 2019, 1:23 PM

Tobi_WMDE_SW moved this task from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2019-09-04 board.Sep 4 2019, 1:23 PM

This isn't possible to demonstrate on the beta cluster, because of configuration differences. Here you can see that the URLs have always been correct on beta commons: https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Log/import

Change 534778 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileExporter@master] Tests for FileImporter URL

https://gerrit.wikimedia.org/r/534778

gerritbot added a project: Patch-For-Review.Sep 6 2019, 9:59 AM

awight moved this task from Demo to Review on the WMDE-QWERTY-Sprint-2019-09-04 board.Sep 6 2019, 10:01 AM