I (@thiemowmde) had a 3 months break from the Move-Files-To-Commons codebase. When I came back, I noticed a few things:
- 2 tests started failing for me locally, but nowhere else.
- About 30 tests are reported as being slow (taking longer than 50 ms).
- I found a few new issues when running the static code analysis my PHPStorm provides.
- I realized we can start using more PHP 7 features now, most notably return types.
Most notable Patch-For-Review:
- https://gerrit.wikimedia.org/r/537332 introduces a PHP 7 feature, where already possible.
- https://gerrit.wikimedia.org/r/536971 removes unused code and improves (self-) documentation.
- https://gerrit.wikimedia.org/r/536127 replaces slow Hamcrest assertions with string comparisons, where possible.
- https://gerrit.wikimedia.org/r/537371 fixes a test depending on local config.
- https://gerrit.wikimedia.org/r/537094 removes a dependency on Config.
- https://gerrit.wikimedia.org/r/537360 removes a (dead) dependency on Config.
- https://gerrit.wikimedia.org/r/537449 documents said dead dependency on Config.
- https://gerrit.wikimedia.org/r/537367 injects config instead of relying on global state.
- https://gerrit.wikimedia.org/r/537636 (re)moves a dependency on MediaWiki core's Language class via dependency inversion. Motivation was all ImportPlanValidator tests being reported as slow.
- https://gerrit.wikimedia.org/r/537095 makes a method private that wasn't supposed to be public.