MMV fails under race condition if slideshow present on page and RL debug set to true
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Sep 20 2019, 12:21 PM

Description

Visit a page with a plain image, and a slideshow
Turn on RL debug (&debug=true)
Try to load MMV by click on the plain image

Observe this fails

Details

	Subject	Repo	Branch	Lines +/-
	Gallery: Don't fire wikipage.content hook twice during init	mediawiki/core	master	+8 -3

Customize query in gerrit

Event Timeline

Esanders created this task.Sep 20 2019, 12:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2019, 12:21 PM

Esanders added a project: MediaWiki-Gallery.Sep 20 2019, 12:21 PM

Esanders updated the task description. (Show Details)

Change 538251 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Gallery: Don't fire wikipage.content hook twice during init

https://gerrit.wikimedia.org/r/538251

gerritbot added a project: Patch-For-Review.Sep 20 2019, 12:23 PM

Change 538251 merged by jenkins-bot:
[mediawiki/core@master] Gallery: Don't fire wikipage.content hook twice during init

https://gerrit.wikimedia.org/r/538251

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 20 2019, 8:01 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2019, 8:10 PM

Jdforrester-WMF closed this task as Resolved.Sep 20 2019, 8:34 PM

Jdforrester-WMF assigned this task to Esanders.

MMV fails under race condition if slideshow present on page and RL debug set to trueClosed, ResolvedPublicActions

Description

Details

Event Timeline

MMV fails under race condition if slideshow present on page and RL debug set to true
Closed, ResolvedPublic
Actions