Page MenuHomePhabricator
Create Task
Maniphest T234109

Section edit link missing when long section title doesn't wrap before viewport right margin
Closed, ResolvedPublic
Actions

Description

The section edit link is not visible (pushed past right border) when a long section title does not wrap before the viewport right margin, on some browsers.

Test example:

If you have a very wide or very high-res monitor, please try this on a 15" laptop, or narrow your window a bit.

Tested on Win7-64. 'Broken' means no edit link appears at certain string-length/window-width combinations; 'Works' means the edit link appears, and functions correctly:

  • Broken on: Safari 5, Opera 63, Chrome 77,
  • Works on: IE 11 (wraps at space before paren), Firefox 56 (wraps at slash)

P.S., my default browser is Opera, but I don't see a Browser Support project for it; if there's another Opera-related project, please add it.

Related Objects

Event Timeline

Mathglot created this task.Sep 27 2019, 11:25 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 27 2019, 11:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mathglot updated the task description. (Show Details)Sep 27 2019, 11:27 PM
Aklapper removed projects: Browser-Support-Apple-Safari, Browser-Support-Android-Google-Chrome, Browser-Support-Firefox, MediaWiki-libs-WrappedString, Section Editing (Mobile), Performance-Team.Sep 28 2019, 11:14 AM
Mathglot added a comment.May 28 2020, 8:43 PM

Adding:

  • broken on Vivaldi 3.0.
matmarex edited projects, added DiscussionTools; removed Talk Pages.Sep 8 2022, 4:50 PM
matmarex closed this task as Invalid.Sep 8 2022, 5:13 PM
matmarex subscribed.

I don't see the issue on the linked page today. This might have been a browser bug that was fixed. Or it might have been the same issue as T298371: Viewport overflow because of data-mw-comment-start/end, now fixed (although that was only reported on Safari).

If you still see the problem, please re-open and add a screenshot.

Mathglot reopened this task as Open.EditedSep 15 2022, 3:31 AM

Re-opened. It still occurs, but the title of the ticket should be changed from "Section edit link..." to "Last title line link...", or "Last right-floated link...", or some such. When the section edit link was the only link on the title line, the description was correct, but now that it isn't anymore (the '[subscribe]' link is now last) the current description is no longer accurate, even though the underlying problem causing it when it was first named is still occurring.

My guess is that the behavior changed when the Talk page subscribe tools were released recently.

T234109 screenshot of missing link on long section title.jpg (762×1 px, 191 KB)

matmarex closed this task as Resolved.Sep 23 2022, 6:59 PM

There is no [subscribe] link on that section, because there are no signatures in it, so it's not treated as a discussion section. It works as expected for me (when I manually change a heading with both [subscribe] and [edit source] to be very long):

image.png (936×2 px, 187 KB)

(the links' placement is a bit weird, but I think this is unavoidable)

If you can reproduce the problem on another page, please re-open again.

Mathglot added a comment.Sep 24 2022, 2:06 AM

It was signed, but not dated. I added a date, and now the [subscribe] link appears. (In a weird place, as you said, but still.)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits