Page MenuHomePhabricator

Add a new message rev-suppressed-no-diff for diff without entry in public log
Closed, ResolvedPublic

Description

If a revision is deleted the diff always shows rev-deleted-no-diff for "normal" users which contains a link to Special:Log/delete. But if one revision is suppressed the log doesn't contains any information. So it would by nice to have a new message rev-suppressed-no-diff which doens't conatins a link to the deletion log.

Nessessary Code Changes in diff/DifferenceInterface.php:
-$wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n",

  • array( 'rev-deleted-no-diff' ) );

+$msg = $suppressed ? 'rev-suppressed-no-diff' : 'rev-deleted-no-diff';
+$wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n", array( $msg) );

System Message Changes:

rev-deleted-no-diff:
-You cannot view this diff because one of the revisions has been '''deleted'''.
-There may be details in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].
+You cannot view this diff because one of the revisions has been '''deleted'''.
+Details can be found in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].

rev-suppressed-no-diff:
+You cannot view this diff because one of the revisions has been '''removed from the public archives'''.


Version: unspecified
Severity: enhancement

Details

Reference
bz21411

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:49 PM
bzimport set Reference to bz21411.

Currently suppression status not hinted at for non-admins anywhere to discourage xml dump searching.

Aaron, please bring this issue to a resolution. Thanks.